Accessibility Improvement : Remove focusing of AztecText control as it's unneeded in TalkBack mode.#927
Merged
jd-alexander merged 1 commit intodevelopfrom Sep 23, 2020
Conversation
This was referenced Sep 16, 2020
mchowning
approved these changes
Sep 18, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Tested and working well. Looks good! Nice work @jd-alexander ! 🎉
I also went through the test steps for #646, which is the PR adding the line you're removing, and I found no issues. ![]()
Contributor
Author
|
Oh nice. Thanks @mchowning 🙇 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #926
Findings
The
AztecTextview was focusing on hover during accessibility mode.Solution
The solution was to modify the
AztecTextAccessibilityDelegatethat was intercepting theMotionEventon hover since that triggered the delegate's logic which involved requesting the focus on theAztecTextview.Testing
AztecTextview.I modified the string content from
EXAMPLEtoQUOTEso testing would be easier.AztecEditor-Android/app/src/main/kotlin/org/wordpress/aztec/demo/MainActivity.kt
Line 462 in f65933f
Screenshot
Video
Reviewing
Only 1 reviewer is needed but anyone can review.
Submitter Checklist
RELEASE-NOTES.txtif necessary.strings.xmlas a part of the integration PR.