Skip to content

Gutenberg: UBE is enabled for all WPCom simple sites#12990

Merged
etoledom merged 1 commit intodevelopfrom
gutenberg/ube-enabled-for-all-wpcom-simple-sites
Sep 21, 2020
Merged

Gutenberg: UBE is enabled for all WPCom simple sites#12990
etoledom merged 1 commit intodevelopfrom
gutenberg/ube-enabled-for-all-wpcom-simple-sites

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Sep 18, 2020

This PR enables the Unsupported Block Editor for all WPCom simple sites.
For Jetpack sites we still check if the user has gutenberg enabled on web.

To test:

  • On a WPCom simple site, open gutenberg with a post that contains an unsupported block.
  • Tap on the unsupported block to open the Unsupported Block Editor.
  • Check that Gutenberg loads on the WebView displaying the unsupported block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 added this to the 15.8 milestone Sep 18, 2020
@marecar3 marecar3 self-assigned this Sep 18, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020

You can test the changes on this Pull Request by downloading the APK here.

etoledom
etoledom approved these changes Sep 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Thank you @marecar3 🎉

guarani
guarani reviewed Sep 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is working when testing a newish WP.com simple site, I get a blank screen on my older WP.com simple site (schrottky.wordpress.com) that used the Classic editor (until it was recently switched to Gutenberg by WP.com).

Screen recording showing blank screen in unsupported block editor

@etoledom etoledom merged commit 9bab0d2 into develop Sep 21, 2020
@etoledom etoledom deleted the gutenberg/ube-enabled-for-all-wpcom-simple-sites branch September 21, 2020 07:46
@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Sep 21, 2020

While this is working when testing a newish WP.com simple site, I get a blank screen on my older WP.com simple site (schrottky.wordpress.com) that used the Classic editor (until it was recently switched to Gutenberg by WP.com).

Screen recording showing blank screen in unsupported block editor

Hey, @guarani thanks for the report. I have fixed that issue on another branch (already reported by @cameronvoell)
which was merged into develop, so it would be good if you can test on the latest WordPressAndroid develop branch?

@designsimply designsimply mentioned this pull request Oct 5, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@guarani guarani guarani left review comments

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marecar3 marecar3

Labels

None yet

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

3 participants

@marecar3 @guarani @etoledom