MediaUpload - Remove dashicons and use icons instead#2660
Merged
Conversation
6 tasks
chipsnyder
approved these changes
Sep 23, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Works well for me. I was only able to test with npm run core start npm start is returning an error that's not related to this PR. Thanks for jumping on this fix :)
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
added 2 commits
September 24, 2020 12:07
# Conflicts: # gutenberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#25576After this PR some dashicons were left to update causing the
MediaUploadcomponent to break on Android. This PR changes those icons to use some from the Icons library.To test check the Gutenberg PR description.
PR submission checklist: