[Mobile] - MediaUpload - Remove dashicons and use icons instead#25576
Merged
[Mobile] - MediaUpload - Remove dashicons and use icons instead#25576
Conversation
2 tasks
|
Size Change: +1 kB (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
chipsnyder
approved these changes
Sep 23, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Tested via the demo app. This is working well for me 👍
There seems to be one other location where this might come up but I'm unsure how to recreate that case. So I'll leave that up to you
Member
Author
Thanks for the review @chipsnyder! I updated the other icon as well to prevent future crashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2660Description
After this PR some dashicons were left to update causing the
MediaUploadcomponent to break on Android. This PR changes those icons to use some from the Icons library.How has this been tested?
Screenshots
Note: The icons are slightly different. cc @iamthomasbishop
We were using for:
Image: https://developer.wordpress.org/resource/dashicons/#format-image
Video: https://developer.wordpress.org/resource/dashicons/#format-video
Update: there was also another icon that was set as default for the
DropdownMenucomponent. This component is used in theHeadingblock but since this block passes its own icon, it wasn't causing issues. I updated it to prevent a future crash.Types of changes
Bug fix
Checklist: