2.x by jarednova · Pull Request #1617 · timber/timber

jarednova · 2017-12-28T21:36:13Z

Ticket: #1580

This will track the progress and tests for 2.x into master

…ss names

jarednova · 2018-05-30T14:32:00Z

tests/test-timber-menu.php

+
+		// Menu item with _menu_item_target set to ''
+		$item = $items[2];
+		$this->assertFalse( '_self', $item->target() );


@gchtr wanted to check on this test (it's failing right now). Should $item->target() register as _self or false in this scenario?

@jarednova Oh! I don’t know why it wasn’t failing for me. But that should probably be:

$this->assertEquals( '_self', $item->target() );

It should definitely return _self. I copied the assertFalse from the test above and forgot to change the assertion method.

Cool, that's what I thought! I have a patch I'll pull in to 2.x

@jarednova See #2019.

…k is intended behavior

codecov · 2018-09-19T03:14:43Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.52%.
The diff coverage is 90.15%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     94.83%   94.31%   -0.53%     
+ Complexity     1527     1507      -20     
============================================
  Files            48       48              
  Lines          3585     3799     +214     
============================================
+ Hits           3400     3583     +183     
- Misses          185      216      +31

Impacted Files	Coverage Δ	Complexity Δ
lib/Cache/WPObjectCacheAdapter.php	`42.85% <ø> (ø)`	`3 <0> (ø)`	⬇️
lib/PostPreview.php	`96.29% <ø> (ø)`	`38 <0> (ø)`	⬇️
lib/FunctionWrapper.php	`92% <ø> (+1.09%)`	`14 <0> (-3)`	⬇️
lib/PostCollection.php	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
lib/PostQuery.php	`100% <ø> (ø)`	`5 <0> (ø)`	⬇️
lib/Request.php	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
lib/Twig_Function.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/Integrations.php	`91.66% <ø> (ø)`	`6 <0> (ø)`	⬇️
lib/PostsIterator.php	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/Pagination.php	`100% <ø> (ø)`	`42 <0> (ø)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf826bd...7167425. Read the comment docs.

codecov · 2018-09-19T03:35:34Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.52%.
The diff coverage is 90.15%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     94.83%   94.31%   -0.53%     
+ Complexity     1527     1507      -20     
============================================
  Files            48       48              
  Lines          3585     3799     +214     
============================================
+ Hits           3400     3583     +183     
- Misses          185      216      +31

Impacted Files	Coverage Δ	Complexity Δ
lib/Cache/WPObjectCacheAdapter.php	`42.85% <ø> (ø)`	`3 <0> (ø)`	⬇️
lib/PostPreview.php	`96.29% <ø> (ø)`	`38 <0> (ø)`	⬇️
lib/FunctionWrapper.php	`92% <ø> (+1.09%)`	`14 <0> (-3)`	⬇️
lib/PostCollection.php	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
lib/PostQuery.php	`100% <ø> (ø)`	`5 <0> (ø)`	⬇️
lib/Request.php	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
lib/Twig_Function.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/Integrations.php	`91.66% <ø> (ø)`	`6 <0> (ø)`	⬇️
lib/PostsIterator.php	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/Pagination.php	`100% <ø> (ø)`	`42 <0> (ø)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae5977...80ee371. Read the comment docs.

codecov · 2018-09-19T03:50:09Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.52%.
The diff coverage is 90.15%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     94.83%   94.31%   -0.53%     
+ Complexity     1527     1507      -20     
============================================
  Files            48       48              
  Lines          3585     3799     +214     
============================================
+ Hits           3400     3583     +183     
- Misses          185      216      +31

Impacted Files	Coverage Δ	Complexity Δ
lib/Cache/WPObjectCacheAdapter.php	`42.85% <ø> (ø)`	`3 <0> (ø)`	⬇️
lib/PostPreview.php	`96.29% <ø> (ø)`	`38 <0> (ø)`	⬇️
lib/FunctionWrapper.php	`92% <ø> (+1.09%)`	`14 <0> (-3)`	⬇️
lib/PostCollection.php	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
lib/PostQuery.php	`100% <ø> (ø)`	`5 <0> (ø)`	⬇️
lib/Request.php	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
lib/Twig_Function.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/Integrations.php	`91.66% <ø> (ø)`	`6 <0> (ø)`	⬇️
lib/PostsIterator.php	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/Pagination.php	`100% <ø> (ø)`	`42 <0> (ø)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae5977...80ee371. Read the comment docs.

codecov · 2018-09-19T03:50:26Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.52%.
The diff coverage is 90.15%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     94.83%   94.31%   -0.53%     
+ Complexity     1527     1507      -20     
============================================
  Files            48       48              
  Lines          3585     3799     +214     
============================================
+ Hits           3400     3583     +183     
- Misses          185      216      +31

Impacted Files	Coverage Δ	Complexity Δ
lib/Cache/WPObjectCacheAdapter.php	`42.85% <ø> (ø)`	`3 <0> (ø)`	⬇️
lib/PostPreview.php	`96.29% <ø> (ø)`	`38 <0> (ø)`	⬇️
lib/FunctionWrapper.php	`92% <ø> (+1.09%)`	`14 <0> (-3)`	⬇️
lib/PostCollection.php	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
lib/PostQuery.php	`100% <ø> (ø)`	`5 <0> (ø)`	⬇️
lib/Request.php	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
lib/Twig_Function.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/Integrations.php	`91.66% <ø> (ø)`	`6 <0> (ø)`	⬇️
lib/PostsIterator.php	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/Pagination.php	`100% <ø> (ø)`	`42 <0> (ø)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae5977...80ee371. Read the comment docs.

codecov · 2018-09-19T03:50:36Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.52%.
The diff coverage is 90.15%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     94.83%   94.31%   -0.53%     
+ Complexity     1527     1507      -20     
============================================
  Files            48       48              
  Lines          3585     3799     +214     
============================================
+ Hits           3400     3583     +183     
- Misses          185      216      +31

Impacted Files	Coverage Δ	Complexity Δ
lib/Cache/WPObjectCacheAdapter.php	`42.85% <ø> (ø)`	`3 <0> (ø)`	⬇️
lib/PostPreview.php	`96.29% <ø> (ø)`	`38 <0> (ø)`	⬇️
lib/FunctionWrapper.php	`92% <ø> (+1.09%)`	`14 <0> (-3)`	⬇️
lib/PostCollection.php	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
lib/PostQuery.php	`100% <ø> (ø)`	`5 <0> (ø)`	⬇️
lib/Request.php	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
lib/Twig_Function.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/Integrations.php	`91.66% <ø> (ø)`	`6 <0> (ø)`	⬇️
lib/PostsIterator.php	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/Pagination.php	`100% <ø> (ø)`	`42 <0> (ø)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae5977...80ee371. Read the comment docs.

codecov · 2018-09-19T03:50:53Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.52%.
The diff coverage is 90.15%.

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     94.83%   94.31%   -0.53%     
+ Complexity     1527     1507      -20     
============================================
  Files            48       48              
  Lines          3585     3799     +214     
============================================
+ Hits           3400     3583     +183     
- Misses          185      216      +31

Impacted Files	Coverage Δ	Complexity Δ
lib/Cache/WPObjectCacheAdapter.php	`42.85% <ø> (ø)`	`3 <0> (ø)`	⬇️
lib/PostPreview.php	`96.29% <ø> (ø)`	`38 <0> (ø)`	⬇️
lib/FunctionWrapper.php	`92% <ø> (+1.09%)`	`14 <0> (-3)`	⬇️
lib/PostCollection.php	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
lib/PostQuery.php	`100% <ø> (ø)`	`5 <0> (ø)`	⬇️
lib/Request.php	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
lib/Twig_Function.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/Integrations.php	`91.66% <ø> (ø)`	`6 <0> (ø)`	⬇️
lib/PostsIterator.php	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/Pagination.php	`100% <ø> (ø)`	`42 <0> (ø)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae5977...80ee371. Read the comment docs.

Co-authored-by: Erik van der Bas <erik@basedonline.nl>

This reverts commit b57670d.

…terator filter

# Conflicts: # README.md

# Conflicts: # bin/timber.php # lib/Timber.php # readme.txt

gchtr · 2023-11-09T08:49:22Z

Timber 2.0 is released: https://github.com/timber/timber/releases/tag/2.0.0.

We kept the 2.x branch and made it the default branch. We’re not going to merge this into master (which was renamed to 1.x). So we can close this pull request.

szepeviktor · 2023-11-10T17:12:20Z

One major version bump of Timber equals 5 children from a female 👱🏻‍♀️

jarednova added a commit that referenced this pull request Dec 29, 2017

ref #1617 -- more cleanup and docs in Post

2bf55dc

jarednova added a commit that referenced this pull request Dec 29, 2017

ref #1617 -- cleanup in Comment

93f560e

jarednova added a commit that referenced this pull request Dec 29, 2017

ref #1617 -- more docs work

dfd27f2

timber deleted a comment from coveralls Dec 29, 2017

jarednova added the 2.0 label Dec 29, 2017

timber deleted a comment from coveralls Jan 3, 2018

timber deleted a comment from coveralls Jan 5, 2018

timber deleted a comment from coveralls Jan 15, 2018

jarednova added a commit that referenced this pull request Mar 5, 2018

ref #1617 -- fixed some merge conflicts; one last instance of old cla…

b417d7e

…ss names

gsalkin mentioned this pull request Mar 5, 2018

Force Timber to use Twig 2.x? #1673

Closed

jarednova commented May 30, 2018

View reviewed changes

jarednova added a commit that referenced this pull request May 30, 2018

ref #1617 #1715 -- fix failing test; then have code match what I thin…

7d86aab

…k is intended behavior

jarednova added a commit that referenced this pull request Jun 1, 2018

ref #1617 -- fix problem test

bc909e5

jarednova added a commit that referenced this pull request Jun 1, 2018

ref #1617 -- resolve merge conflict

2cb06c7

jarednova mentioned this pull request Jun 1, 2018

1617/menu item target #1723

Merged

timber deleted a comment from codecov bot Nov 27, 2018

Levdbas and others added 27 commits October 24, 2023 20:39

last part of performance guide

96fc0a0

fix: exclude tests from PHPStan

fae8554

Merge pull request #2798 from timber/v2-site-overwrite-call-method

dc49063

Merge pull request #2827 from timber/2.x-revert-final-constructors

a5b76bf

Merge pull request #2828 from timber/2.x-exclude-tests-from-phpstan

d130fb1

fix: Update documentation for 2.0 release

ded4599

Fix link

aa130c7

Co-authored-by: Erik van der Bas <erik@basedonline.nl>

Merge pull request #2797 from timber/v2-caching-docs-update

dbb7139

Prepare docs for 2.x

66c3a1a

fix: Fix some anchors

b57670d

Revert "fix: Fix some anchors"

1f2c3b2

This reverts commit b57670d.

fix: Add note about PostsIterator and removal of timber/class/posts_i…

9f90df5

…terator filter

docs: update links to docs in php file

739b346

docs: doc path changes

42ff452

docs: update readme

9f32501

docs: remove video tutorials from readme

468e1b5

docs: update bug_report.yml

ef3da5b

Fix permalink for installation docs

d7163f1

Merge pull request #2835 from timber/2.x-upgrade-guide

30dab17

Merge pull request #2829 from timber/2.x-prepare-release

2ac1a40

Merge branch '2.x' into update-v1-docs-path

8d6285a

# Conflicts: # README.md

Fix installation docs paths

a117ade

Merge pull request #2836 from timber/update-v1-docs-path

34487d9

Merge branch 'master' into 2.x

451e640

# Conflicts: # bin/timber.php # lib/Timber.php # readme.txt

fix: Fix failing tests for WP 6.4

5938c64

fix: Exclude docs folder for PHPStan

6fbf274

Merge pull request #2838 from timber/2.x-fix-tests

ee467c6

gchtr closed this Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

2.x#1617

2.x#1617
jarednova wants to merge 2273 commits into1.xfrom
2.x

jarednova commented Dec 28, 2017

Uh oh!

jarednova May 30, 2018

Uh oh!

gchtr Jun 1, 2018

Uh oh!

jarednova Jun 1, 2018

Uh oh!

gchtr Jun 4, 2019

Uh oh!

codecov bot commented Sep 19, 2018

Uh oh!

codecov bot commented Sep 19, 2018

Uh oh!

codecov bot commented Sep 19, 2018

Uh oh!

codecov bot commented Sep 19, 2018

Uh oh!

codecov bot commented Sep 19, 2018

Uh oh!

codecov bot commented Sep 19, 2018

Uh oh!

gchtr commented Nov 9, 2023

Uh oh!

szepeviktor commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

jarednova commented Dec 28, 2017

Uh oh!

jarednova May 30, 2018

Choose a reason for hiding this comment

Uh oh!

gchtr Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

jarednova Jun 1, 2018

Choose a reason for hiding this comment

Uh oh!

gchtr Jun 4, 2019

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 19, 2018

Codecov Report

Uh oh!

codecov bot commented Sep 19, 2018

Codecov Report

Uh oh!

codecov bot commented Sep 19, 2018

Codecov Report

Uh oh!

codecov bot commented Sep 19, 2018

Codecov Report

Uh oh!

codecov bot commented Sep 19, 2018

Codecov Report

Uh oh!

codecov bot commented Sep 19, 2018

Codecov Report

Uh oh!

gchtr commented Nov 9, 2023

Uh oh!

szepeviktor commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants