Conversation
Member
@Levdbas Yes, I see. These archive pages worked at some time, I guess. I added a fix, see timber/docs#80 (comment). |
gchtr
previously approved these changes
Nov 7, 2023
Member
gchtr
left a comment
There was a problem hiding this comment.
This is looking goood!
Let’s wait with merging this. We’re going to merge it together with the release.
# Conflicts: # README.md
gchtr
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Issue
As discussed in timber/docs#80 we are going to update the docs to live under their own /v1/ and /v2/ prefix. For that to work we need to update all the links in the repo where needed.
Solution
Fix all the links and while at it, I fixed a few more links as well that were pointing from v2 docs back to v1 or links that were pointing to a non-existing anchor link.
Impact
Hopefully minimal. I double checked all the links but it might be so that I missed one or I messed up a path. But that should be close to zero.
Considerations
We refer a few times to https://timber.github.io/docs/reference/. But this page is not working at the moment. @gchtr , can you recall if that index file worked some time ago? And should we fix it? If not, we might want to update these paths (2 times in contributing.md and 1 time in readme.md) as well.