Conversation
nlemoine
approved these changes
Oct 24, 2023
jarednova
approved these changes
Oct 25, 2023
Member
jarednova
left a comment
There was a problem hiding this comment.
LGTM! I had filed a ticket years ago w/ WordPress core about the finals on Post objects. So similar thinking! (though "takes the jelly out of my doughnut is a much more vibrant way to express it")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
final __constructorreally takes the jelly out of my doughnut #2813Issue
The final constructors prevent advanced use cases as described in #2813. We don’t want to make it so hard to work around it. But we first need to figure out a proper solution for this.
Solution
Revert that pull request for 2.x and figure out a better solution in a future release.
Impact
Less trouble to incorporate advanced coding patterns with Timber.
Usage Changes
None.
Considerations
None.
Testing
No.