Conversation
Member
Author
|
@nlemoine Or wait, now it seems to run fine: https://github.com/timber/timber/actions/runs/6808992662/job/18514424700?pr=2838. |
nlemoine
approved these changes
Nov 9, 2023
Member
Author
|
And now, of course tests fail for lower WordPress versions, because the deprecation is not there. But I think that’s fine for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
With the release of WordPress 6.4, we’re running into lots of errors.
Solution
Turns out that WordPress still always calls
the_block_template_skip_link(), which always causes a_deprecated_function()notice. My solution is to add@expectedDeprecatedcalls.I also excluded the
docs/folder from the PHPStan checks.@nlemoine Can we also ignore the docs for the PHP Lint workflow? We’re getting errors there, too: https://github.com/timber/timber/actions/runs/6808609995/job/18513339121?pr=1617.
Impact
Less noise in tests.
Usage Changes
None.
Considerations
Maybe.
Testing
Yes.