Conversation
gchtr
reviewed
Sep 21, 2023
Member
|
I see that you’re still working in this, but thanks a lot for taking this on! |
array is also a valid argument type.
Member
Author
|
Finally took the time to finish the last part and tried to order the guide in a way that makes sense. |
Member
|
Thanks a lot @Levdbas. These updates surely help to understand what’s going on. I want to take some more time to polish the performance docs. There are some sections in there that could just be deleted, like the TLDR; section and I saw some other details I want to improve. I’m moving this to |
Member
Author
|
Should we just merge this for now @gchtr ? The change about the change at twig/cache-extra is then at least documented when people are going to migrate to 2.0. Let me know what you think. |
Member
gchtr
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Issue
The caching docs needs some TLC. In this PR I will try to tackle these three tickets at once.
Solution
Better documentation!
Impact
Better understanding of caching in Timber.
Usage Changes
None.
Considerations
None.
Testing
No.