Skip to content

test: remove P2P tests#5453

Merged
erikgrinaker merged 12 commits intomasterfrom
erik/remove-p2p-tests
Oct 5, 2020
Merged

test: remove P2P tests#5453
erikgrinaker merged 12 commits intomasterfrom
erik/remove-p2p-tests

Conversation

@erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Oct 3, 2020

Replaced by end-to-end tests. Closes #2805, closes #4641.

@erikgrinaker erikgrinaker added the T:test Type: Tests that need love label Oct 3, 2020
@erikgrinaker erikgrinaker self-assigned this Oct 3, 2020
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see so many scripts being deleted

Base automatically changed from erik/e2e-ci to master October 5, 2020 10:44
@erikgrinaker erikgrinaker force-pushed the erik/remove-p2p-tests branch from 556af88 to b2a74fe Compare October 5, 2020 10:45
@erikgrinaker
Copy link
Contributor Author

@tessr In order to merge this, we'll need some changes to the GitHub branch protection settings:

  • setup_dependencies, test_p2p, and test_persistence on CircleCI should no longer be required

  • e2e-tests / test should be required

@tessr
Copy link
Contributor

tessr commented Oct 5, 2020

I've marked setup_dependencies, test_p2p, and test_persistence as no longer required for master, and I'll do the same for any other branches that rely on those tests. I couldn't find an e2e-tests / test, but I did see a job called e2e-ci--should that be required instead?

@erikgrinaker
Copy link
Contributor Author

Hm, odd - it should be e2e-tests / test. See PR actions below and definition here: https://github.com/tendermint/tendermint/blob/master/.github/workflows/e2e.yml

@erikgrinaker
Copy link
Contributor Author

Will merge this for now, we can revisit branch protection settings tomorrow.

@erikgrinaker erikgrinaker added the S:automerge Automatically merge PR when requirements pass label Oct 5, 2020
@erikgrinaker erikgrinaker deleted the erik/remove-p2p-tests branch October 5, 2020 15:52
lovincyrus added a commit that referenced this pull request Oct 5, 2020
* docs: specify TM version in go tutorials (#5427)

Closes #5425

* privval: allow passing options to NewSignerDialerEndpoint (#5434)

Required for #5291 to set timeouts for remote signers.

* config: set statesync.rpc_servers when generating config file (#5433)

Required for #5291, to generate configuration files with state sync RPC servers.

* consensus: check block parts don't exceed maximum block bytes (#5431)

* ci: docker remvoe circleci and add github action (#5420)

* privval: fix ping message encoding (#5441)

Fixes #5371.

* docs: revise ADR 56, documenting short term decision around amnesia evidence  (#5440)

* light: expand on errors and docs (#5443)

* test: add end-to-end testing framework (#5435)

Partial fix for #5291. For details, see [README.md](https://github.com/tendermint/tendermint/blob/erik/e2e-tests/test/e2e/README.md) and [RFC-001](https://github.com/tendermint/tendermint/blob/master/docs/rfc/rfc-001-end-to-end-testing.md).

This only includes a single test case under `test/e2e/tests/`, as a proof of concept - additional test cases will be submitted separately. A randomized testnet generator will also be submitted separately, there a currently just a handful of static testnets under `test/e2e/networks/`. This will eventually replace the current P2P tests and run in CI.

* changelog: add missing date to v0.33.5 release, fix indentation (#5454)

I forgot to add the date when we cut 0.33.5. This fixes that. It also fixes a header indentation issue for 0.33.8.

* test: add basic end-to-end test cases (#5450)

Partial fix for #5291.

This adds a basic set of test cases for core network invariants. Although small, it is sufficient to replace and extend the current set of P2P tests. Further test cases can be added later.

* test: add GitHub action for end-to-end tests (#5452)

Partial fix for #5291.

* fix RPC blockresults reutrn (#5459)

## Description

In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX

* circleci: remove Gitian reproducible_builds job (#5462)

* docs: fix links to adr 56 (#5464)

## Description

fix broken link from a previous change

* test: remove P2P tests (#5453)

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
mergify bot pushed a commit that referenced this pull request Oct 6, 2020
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
melekes pushed a commit that referenced this pull request Oct 9, 2020
melekes pushed a commit that referenced this pull request Oct 9, 2020
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 20, 2020
erikgrinaker added a commit that referenced this pull request Oct 20, 2020
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass T:test Type: Tests that need love

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: run p2p integration tests with all blockchain reactors test: use make localnet instead of current p2p bash setup scripts

4 participants