Skip to content

test: add E2E test for node peering#5465

Merged
mergify[bot] merged 8 commits intomasterfrom
erik/e2e-peers
Oct 6, 2020
Merged

test: add E2E test for node peering#5465
mergify[bot] merged 8 commits intomasterfrom
erik/e2e-peers

Conversation

@erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Oct 5, 2020 •
edited
Loading

This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.

@erikgrinaker erikgrinaker added T:test Type: Tests that need love S:automerge Automatically merge PR when requirements pass labels Oct 5, 2020
@erikgrinaker erikgrinaker self-assigned this Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #5465 into master will decrease coverage by 1.89%.
The diff coverage is 54.00%.

@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   63.29%   61.40%   -1.90%     
==========================================
  Files         181      259      +78     
  Lines       19080    23456    +4376     
==========================================
+ Hits        12077    14402    +2325     
- Misses       5973     7600    +1627     
- Partials     1030     1454     +424
Impacted Files Coverage Δ
abci/client/client.go 40.00% <ø> (ø)
abci/client/grpc_client.go 0.00% <0.00%> (ø)
abci/client/local_client.go 0.00% <0.00%> (ø)
abci/types/pubkey.go 0.00% <0.00%> (ø)
abci/types/util.go 0.00% <0.00%> (ø)
behaviour/reporter.go 46.42% <ø> (-2.06%) ⬇️
blockchain/v1/reactor_fsm.go 70.81% <0.00%> (-3.62%) ⬇️
blockchain/v2/io.go 0.00% <0.00%> (ø)
blockchain/v2/processor_context.go 68.00% <0.00%> (+4.84%) ⬆️
cmd/tendermint/commands/run_node.go 0.00% <0.00%> (ø)
... and 299 more

melekes
melekes approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 8d28e74 into master Oct 6, 2020
@mergify mergify bot deleted the erik/e2e-peers branch October 6, 2020 06:00
melekes pushed a commit that referenced this pull request Oct 9, 2020
@erikgrinaker @melekes
test: add E2E test for node peering (#5465)
f6b7913 
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 20, 2020
@erikgrinaker
test: add E2E test for node peering (#5465)
b231bb5 
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
@erikgrinaker
test: add E2E test for node peering (#5465)
6eb273a 
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
@erikgrinaker
test: add E2E test for node peering (#5465)
3294036 
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
erikgrinaker added a commit that referenced this pull request Oct 22, 2020
@erikgrinaker
test: add E2E test for node peering (#5465)
3a4a6ae 
This was a missing test case from the old P2P tests removed in #5453, which makes sure that all nodes are able to peer with each other regardless of how they discover peers.

Fixes #2795, since the default CI testnet uses a combination of (partially meshed) persistent peers and PEX-based seed nodes.
@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
This was referenced Apr 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erikgrinaker erikgrinaker

Labels

S:automerge Automatically merge PR when requirements pass T:test Type: Tests that need love

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CI testing for dynamic peer discovery

2 participants

@erikgrinaker @melekes