Skip to content

fix RPC blockresults reutrn#5459

Merged
mergify[bot] merged 2 commits intomasterfrom
marko/fix_rpc
Oct 5, 2020
Merged

fix RPC blockresults reutrn#5459
mergify[bot] merged 2 commits intomasterfrom
marko/fix_rpc

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Oct 5, 2020

Description

In blocks_results we use the proto definition of abciResponses:

results, err := env.StateStore.LoadABCIResponses(height)
if err != nil {
return nil, err
}
, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX

@tac0turtle tac0turtle self-assigned this Oct 5, 2020
@tac0turtle tac0turtle added C:rpc Component: JSON RPC, gRPC T:bug Type Bug (Confirmed) labels Oct 5, 2020
@tac0turtle tac0turtle marked this pull request as ready for review October 5, 2020 11:02
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #5459 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5459      +/-   ##
==========================================
+ Coverage   61.37%   61.45%   +0.07%     
==========================================
  Files         259      259              
  Lines       23456    23456              
==========================================
+ Hits        14397    14414      +17     
+ Misses       7605     7593      -12     
+ Partials     1454     1449       -5     
Impacted Files Coverage Δ
privval/signer_server.go 89.47% <0.00%> (-5.27%) ⬇️
blockchain/v2/reactor.go 32.94% <0.00%> (-3.11%) ⬇️
consensus/state.go 68.44% <0.00%> (-0.19%) ⬇️
consensus/reactor.go 74.59% <0.00%> (+0.25%) ⬆️
p2p/pex/pex_reactor.go 79.46% <0.00%> (+0.59%) ⬆️
statesync/snapshots.go 93.27% <0.00%> (+1.68%) ⬆️
libs/clist/clist.go 69.00% <0.00%> (+1.75%) ⬆️
blockchain/v0/reactor.go 63.54% <0.00%> (+1.97%) ⬆️
blockchain/v0/pool.go 78.96% <0.00%> (+2.95%) ⬆️
proxy/multi_app_conn.go 52.70% <0.00%> (+4.05%) ⬆️
... and 1 more

@mergify mergify bot merged commit d7d0ffe into master Oct 5, 2020
@mergify mergify bot deleted the marko/fix_rpc branch October 5, 2020 13:55
tac0turtle added a commit that referenced this pull request Oct 5, 2020
## Description

In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX
tac0turtle added a commit that referenced this pull request Oct 5, 2020
In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX
lovincyrus added a commit that referenced this pull request Oct 5, 2020
* docs: specify TM version in go tutorials (#5427)

Closes #5425

* privval: allow passing options to NewSignerDialerEndpoint (#5434)

Required for #5291 to set timeouts for remote signers.

* config: set statesync.rpc_servers when generating config file (#5433)

Required for #5291, to generate configuration files with state sync RPC servers.

* consensus: check block parts don't exceed maximum block bytes (#5431)

* ci: docker remvoe circleci and add github action (#5420)

* privval: fix ping message encoding (#5441)

Fixes #5371.

* docs: revise ADR 56, documenting short term decision around amnesia evidence  (#5440)

* light: expand on errors and docs (#5443)

* test: add end-to-end testing framework (#5435)

Partial fix for #5291. For details, see [README.md](https://github.com/tendermint/tendermint/blob/erik/e2e-tests/test/e2e/README.md) and [RFC-001](https://github.com/tendermint/tendermint/blob/master/docs/rfc/rfc-001-end-to-end-testing.md).

This only includes a single test case under `test/e2e/tests/`, as a proof of concept - additional test cases will be submitted separately. A randomized testnet generator will also be submitted separately, there a currently just a handful of static testnets under `test/e2e/networks/`. This will eventually replace the current P2P tests and run in CI.

* changelog: add missing date to v0.33.5 release, fix indentation (#5454)

I forgot to add the date when we cut 0.33.5. This fixes that. It also fixes a header indentation issue for 0.33.8.

* test: add basic end-to-end test cases (#5450)

Partial fix for #5291.

This adds a basic set of test cases for core network invariants. Although small, it is sufficient to replace and extend the current set of P2P tests. Further test cases can be added later.

* test: add GitHub action for end-to-end tests (#5452)

Partial fix for #5291.

* fix RPC blockresults reutrn (#5459)

## Description

In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX

* circleci: remove Gitian reproducible_builds job (#5462)

* docs: fix links to adr 56 (#5464)

## Description

fix broken link from a previous change

* test: remove P2P tests (#5453)

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
tac0turtle added a commit that referenced this pull request Oct 7, 2020
melekes pushed a commit that referenced this pull request Oct 9, 2020
## Description

In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:rpc Component: JSON RPC, gRPC S:automerge Automatically merge PR when requirements pass T:bug Type Bug (Confirmed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants