fix RPC blockresults return (#5459) (#5463) #5463
Merged
tac0turtle merged 3 commits intov0.34.0-rc5from Oct 7, 2020
Merged
Conversation
## Description In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly. A clearer divide between proto types and native types is needed. Closes: #XXX
In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly. A clearer divide between proto types and native types is needed. Closes: #XXX
erikgrinaker
approved these changes
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## v0.34.0-rc5 #5463 +/- ##
==============================================
Coverage ? 61.33%
==============================================
Files ? 259
Lines ? 23435
Branches ? 0
==============================================
Hits ? 14374
Misses ? 7599
Partials ? 1462 |
Contributor
|
This probably needs a changelog entry. Also, when backporting we should keep the original PR/commit message, otherwise the branch history will just be full of "backport" commit messages which isn't particularly informative. |
melekes
approved these changes
Oct 6, 2020
melekes
approved these changes
Oct 6, 2020
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add a description of the changes that this PR introduces and the files that
are the most critical to review.
Closes: #XXX