Skip to content

config: set statesync.rpc_servers when generating config file#5433

Merged
mergify[bot] merged 2 commits intomasterfrom
erik/config-rpcservers
Oct 1, 2020
Merged

config: set statesync.rpc_servers when generating config file#5433
mergify[bot] merged 2 commits intomasterfrom
erik/config-rpcservers

Conversation

@erikgrinaker
Copy link
Contributor

Required for #5291, to generate configuration files with state sync RPC servers.

@erikgrinaker erikgrinaker added the S:automerge Automatically merge PR when requirements pass label Sep 30, 2020
@erikgrinaker erikgrinaker self-assigned this Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #5433 into master will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #5433      +/-   ##
==========================================
+ Coverage   61.35%   61.39%   +0.03%     
==========================================
  Files         259      259              
  Lines       23439    23442       +3     
==========================================
+ Hits        14382    14393      +11     
+ Misses       7603     7594       -9     
- Partials     1454     1455       +1     
Impacted Files Coverage Δ
config/toml.go 63.63% <75.00%> (+2.66%) ⬆️
privval/signer_endpoint.go 72.72% <0.00%> (-6.07%) ⬇️
privval/signer_server.go 89.47% <0.00%> (-5.27%) ⬇️
privval/signer_listener_endpoint.go 86.25% <0.00%> (-2.50%) ⬇️
blockchain/v0/reactor.go 60.59% <0.00%> (-0.99%) ⬇️
consensus/replay.go 70.53% <0.00%> (-0.83%) ⬇️
p2p/pex/pex_reactor.go 80.35% <0.00%> (-0.60%) ⬇️
p2p/pex/addrbook.go 68.84% <0.00%> (-0.51%) ⬇️
proxy/multi_app_conn.go 48.64% <0.00%> (ø)
consensus/state.go 68.41% <0.00%> (+0.09%) ⬆️
... and 7 more

@mergify mergify bot merged commit 2a0fa66 into master Oct 1, 2020
@mergify mergify bot deleted the erik/config-rpcservers branch October 1, 2020 04:21
erikgrinaker added a commit that referenced this pull request Oct 1, 2020
Required for #5291, to generate configuration files with state sync RPC servers.
erikgrinaker added a commit that referenced this pull request Oct 1, 2020
…#5438)

Required for #5291, to generate configuration files with state sync RPC servers.
lovincyrus added a commit that referenced this pull request Oct 5, 2020
* docs: specify TM version in go tutorials (#5427)

Closes #5425

* privval: allow passing options to NewSignerDialerEndpoint (#5434)

Required for #5291 to set timeouts for remote signers.

* config: set statesync.rpc_servers when generating config file (#5433)

Required for #5291, to generate configuration files with state sync RPC servers.

* consensus: check block parts don't exceed maximum block bytes (#5431)

* ci: docker remvoe circleci and add github action (#5420)

* privval: fix ping message encoding (#5441)

Fixes #5371.

* docs: revise ADR 56, documenting short term decision around amnesia evidence  (#5440)

* light: expand on errors and docs (#5443)

* test: add end-to-end testing framework (#5435)

Partial fix for #5291. For details, see [README.md](https://github.com/tendermint/tendermint/blob/erik/e2e-tests/test/e2e/README.md) and [RFC-001](https://github.com/tendermint/tendermint/blob/master/docs/rfc/rfc-001-end-to-end-testing.md).

This only includes a single test case under `test/e2e/tests/`, as a proof of concept - additional test cases will be submitted separately. A randomized testnet generator will also be submitted separately, there a currently just a handful of static testnets under `test/e2e/networks/`. This will eventually replace the current P2P tests and run in CI.

* changelog: add missing date to v0.33.5 release, fix indentation (#5454)

I forgot to add the date when we cut 0.33.5. This fixes that. It also fixes a header indentation issue for 0.33.8.

* test: add basic end-to-end test cases (#5450)

Partial fix for #5291.

This adds a basic set of test cases for core network invariants. Although small, it is sufficient to replace and extend the current set of P2P tests. Further test cases can be added later.

* test: add GitHub action for end-to-end tests (#5452)

Partial fix for #5291.

* fix RPC blockresults reutrn (#5459)

## Description

In blocks_results we use the proto definition of abciResponses: https://github.com/tendermint/tendermint/blob/2672b91ab099b8b02f3afabae4a0a745acd93c3f/rpc/core/blocks.go#L152-L155, this leads to the use of the proto definition of the pubkey which is an interface in go (oneof). The interface must be registered with the JSON encoder to have it work correctly.

A clearer divide between proto types and native types is needed.

Closes: #XXX

* circleci: remove Gitian reproducible_builds job (#5462)

* docs: fix links to adr 56 (#5464)

## Description

fix broken link from a previous change

* test: remove P2P tests (#5453)

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
lovincyrus added a commit that referenced this pull request Oct 5, 2020
* docs: specify TM version in go tutorials (#5427)

Closes #5425

* privval: allow passing options to NewSignerDialerEndpoint (#5434)

Required for #5291 to set timeouts for remote signers.

* config: set statesync.rpc_servers when generating config file (#5433)

Required for #5291, to generate configuration files with state sync RPC servers.

* consensus: check block parts don't exceed maximum block bytes (#5431)

* ci: docker remvoe circleci and add github action (#5420)

* privval: fix ping message encoding (#5441)

Fixes #5371.

* docs: revise ADR 56, documenting short term decision around amnesia evidence  (#5440)

* light: expand on errors and docs (#5443)

* makefile: config build-docs for branch and path prefix

* update versions with new 0.33 branch

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Erik Grinaker <erik@interchain.berlin>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
melekes pushed a commit that referenced this pull request Oct 9, 2020
Required for #5291, to generate configuration files with state sync RPC servers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants