Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Apr 21, 2023

📚 Context

This PR adds additional module attributions to our telemetry related to LLM ecosystem. If a script uses one of the modules from attribution, this will be added to the anonymous page profile telemetry.

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

🧪 Testing Done

We are not testing the validity of this module name, since it would require adding a lot of test dependencies.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@lukasmasuch lukasmasuch marked this pull request as ready for review April 21, 2023 19:02
@lukasmasuch lukasmasuch added the security-assessment-completed Security assessment has been completed for PR label Apr 21, 2023
@lukasmasuch lukasmasuch merged commit 6916c99 into develop Apr 21, 2023
tconkling added a commit to tconkling/streamlit that referenced this pull request Apr 24, 2023
* develop:
  Removing viz-1.8.0.min.js (streamlit#6520)
  st.experimental_connection: The big merge (streamlit#6487)
  Add additional attributions (streamlit#6536)
  Fix code block font change (streamlit#6535)
  Fully remove email from new session message (streamlit#6516)
  Clarify what telemetry data our backend stores (streamlit#6463)
  Update emojis to latest state (streamlit#6532)
  Add support for pandas 2.0 (streamlit#6507)
  Fix regression in visibility of `st.code`'s copy-to-clipboard button (streamlit#6498)
  Fix E2E image (streamlit#6524)
  Add tenacity as dependency (streamlit#6529)
@vdonato vdonato deleted the feature/add-llm-attributions branch November 2, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants