Add tenacity as dependency #6529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconkling
approved these changes
Apr 20, 2023
Contributor
tconkling
left a comment
There was a problem hiding this comment.
Should we also pre-emptively pin to < 9.0? (I don't have a strong opinion about this, and we don't do it already for all dependencies - but it seems like the direction we should be going)
Collaborator
Author
Seems like it'd be a good idea for good practice's sake -- will do! |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 24, 2023
* develop: Removing viz-1.8.0.min.js (streamlit#6520) st.experimental_connection: The big merge (streamlit#6487) Add additional attributions (streamlit#6536) Fix code block font change (streamlit#6535) Fully remove email from new session message (streamlit#6516) Clarify what telemetry data our backend stores (streamlit#6463) Update emojis to latest state (streamlit#6532) Add support for pandas 2.0 (streamlit#6507) Fix regression in visibility of `st.code`'s copy-to-clipboard button (streamlit#6498) Fix E2E image (streamlit#6524) Add tenacity as dependency (streamlit#6529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
After trying a decent amount to avoid adding this as a core dependency because it's only used
for a few first-party connections in the upcoming
st.experimental_connectionfeature (see#6487), we decided that this package is sufficiently
small and self-contained that we might as well just add it as a requirement.