Add support for pandas 2.0 #6507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Some seemingly unrelated tests now fail on CI with the new updated set of dependencies. The root cause seems to be that the tests in question do not work when From a quick look at the tornado docs, the This seems like a separate issue to the pandas dependency. Help fixing this would be welcome! |
Collaborator
|
@connortann Thanks a lot for the PR and the info about the CI issue 👍 we will most likely merge this PR today. I also just merged a fix for the tornado issue into develop. I assume this will also fix the CI in this PR once you merge with the latest develop. |
4936fe4 to
0f6c5a9
Compare
Co-authored-by: Lukas Masuch <Lukas.Masuch@gmail.com>
kmcgrady
approved these changes
Apr 21, 2023
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 24, 2023
* develop: Removing viz-1.8.0.min.js (streamlit#6520) st.experimental_connection: The big merge (streamlit#6487) Add additional attributions (streamlit#6536) Fix code block font change (streamlit#6535) Fully remove email from new session message (streamlit#6516) Clarify what telemetry data our backend stores (streamlit#6463) Update emojis to latest state (streamlit#6532) Add support for pandas 2.0 (streamlit#6507) Fix regression in visibility of `st.code`'s copy-to-clipboard button (streamlit#6498) Fix E2E image (streamlit#6524) Add tenacity as dependency (streamlit#6529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Adds support for pandas 2.0. Closes #6413
Pandas 2.0 has now been released for several weeks; however, streamlit's
setup.pyhas a pin that prevents use with pandas 2. I believe the required code changes in streamlit to allow compatibility with pandas have already been implemented by #6378.The remaining tasks seem to be to remove the prevous dependency constraint, and to ensure the test suite runs against the new version of pandas and passes.
🧠 Description of Changes
Adds support for pandas 2.0 by removing the pin in
setup.py🧪 Testing Done
As I understand, this change will mean the
py_version (MAX)CI job will test against pandas 2.X, and thepy_version (MIN)job will continue testing against 1.X.However, in future perhaps it's worth expanding these tests to ensure that streamlit will always be tested against the different major versions of pandas, regardless of which python versions are supported? Or, more generally, expanding the CI to test streamlit against the lower bound versions of all dependencies? From a previous comment:
Originally posted by @lukasmasuch in #6378 (comment)
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.