Fully remove email from new session message #6516
Conversation
| string email = 2; | ||
|
|
||
| // DEPRECATED: | ||
| // string email = 2; |
There was a problem hiding this comment.
I'm not 100% sure about the latest state of protobuf compatibility. Can I actually remove this property here, or should I keep it in for compatibility reasons even though it won't get used anymore? @vdonato @tconkling
There was a problem hiding this comment.
it's fine to remove it - our current pattern is to replace the removed field reserved 2; so that if someone tries to reuse the ID it will actually throw a protobuf compile error.
There was a problem hiding this comment.
(So we should do that here)
| string email = 2; | ||
|
|
||
| // DEPRECATED: | ||
| // string email = 2; |
There was a problem hiding this comment.
it's fine to remove it - our current pattern is to replace the removed field reserved 2; so that if someone tries to reuse the ID it will actually throw a protobuf compile error.
| string email = 2; | ||
|
|
||
| // DEPRECATED: | ||
| // string email = 2; |
There was a problem hiding this comment.
(So we should do that here)
* develop: Removing viz-1.8.0.min.js (streamlit#6520) st.experimental_connection: The big merge (streamlit#6487) Add additional attributions (streamlit#6536) Fix code block font change (streamlit#6535) Fully remove email from new session message (streamlit#6516) Clarify what telemetry data our backend stores (streamlit#6463) Update emojis to latest state (streamlit#6532) Add support for pandas 2.0 (streamlit#6507) Fix regression in visibility of `st.code`'s copy-to-clipboard button (streamlit#6498) Fix E2E image (streamlit#6524) Add tenacity as dependency (streamlit#6529)
📚 Context
The previous PR #6464 removed the usage of the identify event in Segment. Thereby, it is not required anymore that we send the author email to the frontend in the NewSession proto message. This PR removes the last aspects related to this, 1) the email from the proto message 2) the logic to populate this property 3) Remove email property from test mocks.
A bit more context is in this conversation.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.