deprecation_util.py (formerly beta_util.py)
#5754
Merged
+191
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconkling
commented
Nov 22, 2022
| @@ -0,0 +1,121 @@ | |||
| # Copyright (c) Streamlit Inc. (2018-2022) Snowflake Inc. (2022) | |||
Contributor
Author
There was a problem hiding this comment.
This is just a renamed version of beta_util_test.py. The tests are now parameterized on PrereleaseAPIType, so that they test both beta_ and experimental_ deprecation warnings.
| has_shown_beta_warning = True | ||
| _show_beta_warning(obj_name, date) | ||
| nonlocal has_shown_graduation_warning | ||
| if not has_shown_graduation_warning: |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
| """ | ||
|
|
||
| has_shown_beta_warning = False | ||
| has_shown_graduation_warning = False |
Check notice
Code scanning / CodeQL
Unused local variable
willhuang1997
approved these changes
Nov 22, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 22, 2022
* develop: `deprecation_util.py` (formerly `beta_util.py`) (streamlit#5754) Hoist element message data creation out of loop (streamlit#5734) Fail tests when all snapshots are not committed (streamlit#5729) Wrap type in quotes to support lower versions of protobuf (streamlit#5746) Fix py_snowflake for Nightly, Release Candidate & Release (streamlit#5747) Add GitHub Actions configuration to Dependabot (streamlit#5722) Fix snowpark integration test workflow (streamlit#5736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beta_utiltodeprecation_utilexperimental_methods