Skip to content

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Nov 21, 2022

📚 Context

python_versions.yml when triggered from a workflow_dispatch event (Nightly, Release Candidate, Release) does not have secrets access unless the workflow is specifically passed the secret(s). The PR passes the PARAMETER_PASSWORD necessary for py_snowflake test.

Docs used as reference here.

  • What kind of change does this PR introduce?
    • Bugfix

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Nov 21, 2022
@mayagbarnes mayagbarnes changed the title [WIP] Fix py_snowflake secrets access in Nightly, Release Candidate & Release [WIP] Fix py_snowflake for Nightly, Release Candidate & Release Nov 22, 2022
@mayagbarnes mayagbarnes changed the title [WIP] Fix py_snowflake for Nightly, Release Candidate & Release Fix py_snowflake for Nightly, Release Candidate & Release Nov 22, 2022
@mayagbarnes mayagbarnes marked this pull request as ready for review November 22, 2022 00:55
@mayagbarnes mayagbarnes merged commit bfede8c into streamlit:develop Nov 22, 2022
@mayagbarnes mayagbarnes deleted the nightly-snowflake branch November 22, 2022 02:15
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 22, 2022
* develop:
  `deprecation_util.py` (formerly `beta_util.py`) (streamlit#5754)
  Hoist element message data creation out of loop (streamlit#5734)
  Fail tests when all snapshots are not committed (streamlit#5729)
  Wrap type in quotes to support lower versions of protobuf (streamlit#5746)
  Fix py_snowflake for Nightly, Release Candidate & Release (streamlit#5747)
  Add GitHub Actions configuration to Dependabot (streamlit#5722)
  Fix snowpark integration test workflow (streamlit#5736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants