-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix snowpark integration test workflow #5736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83dc2d0 to
5c4b362
Compare
9 tasks
mayagbarnes
commented
Nov 18, 2022
Co-authored-by: Kamil Breguła <kamil.bregula@snowflake.com>
Collaborator
Author
|
Separated the fix (hopefully) for nightlies into this related PR |
sfc-gh-kmcgrady
approved these changes
Nov 22, 2022
kmcgrady
approved these changes
Nov 22, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 22, 2022
* develop: `deprecation_util.py` (formerly `beta_util.py`) (streamlit#5754) Hoist element message data creation out of loop (streamlit#5734) Fail tests when all snapshots are not committed (streamlit#5729) Wrap type in quotes to support lower versions of protobuf (streamlit#5746) Fix py_snowflake for Nightly, Release Candidate & Release (streamlit#5747) Add GitHub Actions configuration to Dependabot (streamlit#5722) Fix snowpark integration test workflow (streamlit#5736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
The snowpark integration test in
python-versons.ymlwill fail for all forks because forks don't have secrets access - necessary for theDecrypt credentialsstep inpy_snowpark. This adjusts the if statement to check if the PR is coming from a fork.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.