Skip to content

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Nov 18, 2022

📚 Context

The snowpark integration test in python-versons.yml will fail for all forks because forks don't have secrets access - necessary for the Decrypt credentials step in py_snowpark. This adjusts the if statement to check if the PR is coming from a fork.

  • What kind of change does this PR introduce?
    • Other, please describe: Test Fix

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes changed the title [WIP] Fix snowpark integration test workflow Fix snowpark integration test workflow Nov 18, 2022
@mayagbarnes mayagbarnes marked this pull request as ready for review November 18, 2022 21:11
@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Nov 18, 2022
mayagbarnes and others added 2 commits November 21, 2022 11:48
Co-authored-by: Kamil Breguła <kamil.bregula@snowflake.com>
@mayagbarnes
Copy link
Collaborator Author

Separated the fix (hopefully) for nightlies into this related PR

@mayagbarnes mayagbarnes merged commit ea623d5 into streamlit:develop Nov 22, 2022
@mayagbarnes mayagbarnes deleted the fix-snowpark branch November 22, 2022 00:57
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 22, 2022
* develop:
  `deprecation_util.py` (formerly `beta_util.py`) (streamlit#5754)
  Hoist element message data creation out of loop (streamlit#5734)
  Fail tests when all snapshots are not committed (streamlit#5729)
  Wrap type in quotes to support lower versions of protobuf (streamlit#5746)
  Fix py_snowflake for Nightly, Release Candidate & Release (streamlit#5747)
  Add GitHub Actions configuration to Dependabot (streamlit#5722)
  Fix snowpark integration test workflow (streamlit#5736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants