Hoist element message data creation out of loop #5734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to reset the callstack's local data after we are done adding the widget/media element to the message list for each cached function we are running in. Moving the creation of the message data class out of the loop, and saving it to each of the lists, accomplishes this with the bonus of saving some memory use.
We can't just early return because we need to do some cleanup. Normally it shouldn't be possible to hit this code with values that cause problems, but it can happen in tests that fiddle with internals by patching.
kajarenc
approved these changes
Nov 22, 2022
Collaborator
|
LGTM 👍 |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 22, 2022
* develop: `deprecation_util.py` (formerly `beta_util.py`) (streamlit#5754) Hoist element message data creation out of loop (streamlit#5734) Fail tests when all snapshots are not committed (streamlit#5729) Wrap type in quotes to support lower versions of protobuf (streamlit#5746) Fix py_snowflake for Nightly, Release Candidate & Release (streamlit#5747) Add GitHub Actions configuration to Dependabot (streamlit#5722) Fix snowpark integration test workflow (streamlit#5736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to reset the callstack's local data after we are done adding the widget/media element to the message list for each cached function we are running in. Moving the creation of the message data class out of the loop, and saving it to each of the lists, accomplishes this with the bonus of saving some memory use.
📚 Context
🧠 Description of Changes
Hoist element message data creation out of loop in
save_element_message🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
experimental_allow_widgets=Truedoesn't work in nested@st.experimental_singleton#5677