Wrap type in quotes to support lower versions of protobuf #5746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
approved these changes
Nov 21, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 22, 2022
* develop: `deprecation_util.py` (formerly `beta_util.py`) (streamlit#5754) Hoist element message data creation out of loop (streamlit#5734) Fail tests when all snapshots are not committed (streamlit#5729) Wrap type in quotes to support lower versions of protobuf (streamlit#5746) Fix py_snowflake for Nightly, Release Candidate & Release (streamlit#5747) Add GitHub Actions configuration to Dependabot (streamlit#5722) Fix snowpark integration test workflow (streamlit#5736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seemingly broke streamlit in 1.15.0 in #5742 and https://discuss.streamlit.io/t/version-1-15-returns-error/33523/10 and https://discuss.streamlit.io/t/streamlit-1-15-0-hello-run-error/33571 and likely more.
It looks like the bug is being caused by protobuf versions from my debugging since I don't see that ValueType in 3.19.6. https://github.com/protocolbuffers/protobuf/blob/v3.19.6/python/google/protobuf/internal/enum_type_wrapper.py. I also tested it out and my theory holds true if u install protobuf==3.19.6 and run streamlit --version.
I think we should add dependency changes to make sure they have the correct protobuf version.
UPDATE: We just need to change the return type as a string