Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Unexport some externally irrelevant symbols from uploadstore#63647

Merged
eseliger merged 1 commit into
mainfrom
es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore
Jul 10, 2024
Merged

Unexport some externally irrelevant symbols from uploadstore#63647
eseliger merged 1 commit into
mainfrom
es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore

Conversation

@eseliger

@eseliger eseliger commented Jul 4, 2024

Copy link
Copy Markdown
Member

These symbols aren't used outside of the package, so unexporting them for a cleaner API surface.

Test plan:

Go compiler doesn't complain.

@cla-bot cla-bot Bot added the cla-signed label Jul 4, 2024
This was referenced Jul 4, 2024
Merged
Merged
Merged
Merged
@eseliger Graphite App

eseliger commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jul 4, 2024
This was referenced Jul 4, 2024
Merged
Merged
Merged
Merged
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from 583020e to 4356fb1 Compare July 4, 2024 20:29
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from 41f90b8 to b582762 Compare July 4, 2024 20:29
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from 4356fb1 to 4656299 Compare July 5, 2024 05:15
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from b582762 to 3f0f443 Compare July 5, 2024 05:15
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from 4656299 to 9ec5da6 Compare July 5, 2024 07:36
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from 3f0f443 to c7fe056 Compare July 5, 2024 07:36
@eseliger eseliger mentioned this pull request Jul 5, 2024
Merged
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from 9ec5da6 to 9531a6d Compare July 5, 2024 11:28
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from c7fe056 to 3d8e03d Compare July 5, 2024 11:28
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch 2 times, most recently from a894608 to f8003f9 Compare July 9, 2024 22:37
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from 3d8e03d to d01bc3b Compare July 9, 2024 22:37
@eseliger eseliger marked this pull request as ready for review July 9, 2024 23:00
@eseliger eseliger requested a review from a team July 9, 2024 23:00
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from f8003f9 to 4bd8522 Compare July 9, 2024 23:25
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from d01bc3b to 3fb5d88 Compare July 9, 2024 23:25
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from 4bd8522 to ea0ef4f Compare July 9, 2024 23:55
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from 3fb5d88 to 1cc6bcc Compare July 9, 2024 23:56
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from ea0ef4f to d68d906 Compare July 10, 2024 00:05
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from 1cc6bcc to 83f55af Compare July 10, 2024 00:05
@eseliger eseliger force-pushed the es/07-03-removeunusedpackage branch from d68d906 to 940b51b Compare July 10, 2024 00:21
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from 83f55af to a950eff Compare July 10, 2024 00:21
@eseliger eseliger changed the base branch from es/07-03-removeunusedpackage to graphite-base/63647 July 10, 2024 00:30
@eseliger eseliger changed the base branch from graphite-base/63647 to main July 10, 2024 00:31
@eseliger
Unexport some externally irrelevant symbols from uploadstore
07a01b4 
These symbols aren't used outside of the package, so unexporting them for a cleaner API surface.

Test plan:

Go compiler doesn't complain.
@eseliger eseliger force-pushed the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch from a950eff to 07a01b4 Compare July 10, 2024 00:32
@eseliger eseliger merged commit 2e392e0 into main Jul 10, 2024
@eseliger Graphite App

eseliger commented Jul 10, 2024

Copy link
Copy Markdown
Member Author

Merge activity

@eseliger eseliger deleted the es/07-03-unexportsomeexternallyirrelevantsymbolsfromuploadstore branch July 10, 2024 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@camdencheek camdencheek camdencheek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eseliger @camdencheek