This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codygateway: Use only one redis pool and make REDIS_ENDPOINT a clear requirement in config#63625
Merged
eseliger merged 1 commit intoJul 9, 2024
Conversation
Member
Author
57f97bb to
30c9cd5
Compare
This was referenced Jul 4, 2024
Merged
2e0bd7f to
44eb2a8
Compare
30c9cd5 to
489e2f9
Compare
44eb2a8 to
0d98249
Compare
489e2f9 to
012276e
Compare
2c8c0fd to
5666b30
Compare
012276e to
483dc2d
Compare
bobheadxi
approved these changes
Jul 8, 2024
5666b30 to
cd47721
Compare
483dc2d to
cf2853c
Compare
…requirement in config Currently, nothing really tells that Cody Gateway needs redis, the env var for finding the address is hidden somewhere deep in the redispool package. In practice, we only use one redis instance, but at some point we started using both redispool.Cache and redispool.Store, which means we maintain two connection pools, leading to more than expected connections. Test plan: Code review and CI.
cf2853c to
3e1cfbd
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, nothing really tells that Cody Gateway needs redis, the env var for finding the address is hidden somewhere deep in the redispool package.
In practice, we only use one redis instance, but at some point we started using both redispool.Cache and redispool.Store, which means we maintain two connection pools, leading to more than expected connections.
Test plan:
Code review and CI.