This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove old cache cleanup method#63645
Merged
Merged
Conversation
This was referenced Jul 4, 2024
Merged
Member
Author
This was referenced Jul 4, 2024
Merged
This was referenced Jul 4, 2024
30c9cd5 to
489e2f9
Compare
09ddb38 to
bc493e4
Compare
489e2f9 to
012276e
Compare
bc493e4 to
254b95f
Compare
012276e to
483dc2d
Compare
254b95f to
f6f36f0
Compare
f6f36f0 to
52031e6
Compare
ggilmore
approved these changes
Jul 8, 2024
483dc2d to
cf2853c
Compare
52031e6 to
52a6cc0
Compare
cf2853c to
3e1cfbd
Compare
52a6cc0 to
3d39bf3
Compare
We have been using v2 data since >5 years now, this should be safe to remove. As a side-effect, we have one less background task running in frontend, which means it ran N times in horizontally scaled environments, which isn't exactly useful. Test plan: Code review.
3d39bf3 to
fddcfb4
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using v2 data since >5 years now, this should be safe to remove.
As a side-effect, we have one less background task running in frontend, which means it ran N times in horizontally scaled environments, which isn't exactly useful.
Test plan:
Code review.