Skip to content

std: organise sys::pal::os#153413

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
joboet:organize-pal-os
Mar 9, 2026
Merged

std: organise sys::pal::os#153413
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
joboet:organize-pal-os

Conversation

@joboet
Copy link
Member

@joboet joboet commented Mar 4, 2026

Continuing #153341, this moves around some functions in sys::pal, so that pal::os only contains standard-path-related code (which I'll move later as part of #117276).

Best reviewed commit-by-commit.

@rustbot rustbot added O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2026
@joboet joboet marked this pull request as ready for review March 4, 2026 16:05
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this wasn't strictly necessary, but I figured since I was moving cvt/cvt_r too this just makes sense. Especially since wasi/mod.rs is now defining pretty much the same things as the UNIX version.

use crate::sys::unsupported;
use crate::{fmt, io};

// Add a few symbols not in upstream `libc` just yet.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's no longer true (except for __wasilibc_get_environ).

@Mark-Simulacrum
Copy link
Member

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

📌 Commit d31aecf has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 9, 2026
…ulacrum

std: organise `sys::pal::os`

Continuing rust-lang#153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of rust-lang#117276).

Best reviewed commit-by-commit.
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
Rollup of 6 pull requests

Successful merges:

 - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size)
 - #153413 (std: organise `sys::pal::os`)
 - #139692 (Rustfmt now support use closures)
 - #153244 (tools: remote-test-server: Add UEFI run support)
 - #153305 (Adapt codegen test to accept operand bundles)
 - #153340 (tweak r-a default settings)
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
Rollup of 6 pull requests

Successful merges:

 - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size)
 - #153413 (std: organise `sys::pal::os`)
 - #139692 (Rustfmt now support use closures)
 - #153244 (tools: remote-test-server: Add UEFI run support)
 - #153305 (Adapt codegen test to accept operand bundles)
 - #153340 (tweak r-a default settings)
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152847 (Test for armv7 `get_unchecked(...)` inlining)
 - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size)
 - #153413 (std: organise `sys::pal::os`)
 - #139692 (Rustfmt now support use closures)
 - #152800 (Adds recursion limit into FindParamInClause)
 - #153244 (tools: remote-test-server: Add UEFI run support)
 - #153305 (Adapt codegen test to accept operand bundles)
 - #153340 (tweak r-a default settings)
 - #153509 (Cleanup unused diagnostic emission methods - part 2)
 - #153527 (Fix LegacyKeyValueFormat report from docker build: ohos)
 - #153594 (Move some ui tests)
@rust-bors rust-bors bot merged commit b8e01ed into rust-lang:main Mar 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 9, 2026
rust-timer added a commit that referenced this pull request Mar 9, 2026
Rollup merge of #153413 - joboet:organize-pal-os, r=Mark-Simulacrum

std: organise `sys::pal::os`

Continuing #153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of #117276).

Best reviewed commit-by-commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants