Closed
Conversation
Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below: 1. Use rust-lld linker: `bootstrap.toml` ```toml [rust] lld = true [target.x86_64-unknown-uefi] linker = "rust-lld" ``` 2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional. ```shell fs1: run.efi --sequential --bind "10.0.2.15:12345" --batch ``` 3. Launch remote-test-server in QEMU. I am using uefi-run script [0]. ```shell uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi -n --startup startup.nsh --tcp-port 12345 ``` 4. Run tests: ```shell RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1 ``` [0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run Signed-off-by: Ayush Singh <ayush@beagleboard.org>
… bound to __rust_alloc size LLVM emits a lower bound of 8 for the size parameter to __rust_alloc when targeting x86_64-unknown-hermit. Since that is also completely valid, relax the lower bound check.
1. Explain that you need to make paths absolute in helix settings 2. Use the correct compiler (set `RUSTC` and `CARGO` to stage0, instead of `RUSTUP_TOOLCHAIN=nightly`) 3. Add comments to vscode and zed settings
…op-lower-bound-hermit, r=Mark-Simulacrum tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size LLVM emits a lower bound of 8 for the size parameter to `__rust_alloc` when targeting `x86_64-unknown-hermit`. Since that is also completely valid, relax the lower bound check. I'm not really sure why LLVM is able to infer this - with the same setup targeting `x86_64-unknown-linux-gnu` I also see the lower bound of 0. Not that it's wrong, but I'd be curious to know which codegen options play into this.
…ulacrum std: organise `sys::pal::os` Continuing rust-lang#153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of rust-lang#117276). Best reviewed commit-by-commit.
…r=Mark-Simulacrum Rustfmt now support use closures This should be merged when rust-lang/rustfmt#6532 is used by CI's rustfmt.
…mulacrum tools: remote-test-server: Add UEFI run support Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below: 1. Use rust-lld linker: `bootstrap.toml` ```toml [rust] lld = true [target.x86_64-unknown-uefi] linker = "rust-lld" ``` 2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional. ```shell fs1: run.efi --sequential --bind "10.0.2.15:12345" --batch ``` 3. Launch remote-test-server in QEMU. I am using uefi-run script [0]. ```shell uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi -n --startup startup.nsh --tcp-port 12345 ``` 4. Run tests: ```shell RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1 ``` Requires: rust-lang#151014 @rustbot label +O-UEFI cc @nicholasbishop [0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run
…crum Adapt codegen test to accept operand bundles The updated test current fails when rustc is built with HEAD LLVM: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/44013/steps/canvas?sid=019cafec-3cca-44b2-aa9f-b41c0a940e8b Likely as a result of llvm/llvm-project#169923 Since the new codegen merges two lines into one, I couldn't figure out a way to make the test work on both LLVM versions without introducing revisions. (Though I could instead make the test run on only LLVM 23+). @rustbot label llvm-main
…=Mark-Simulacrum tweak r-a default settings 1. Explain that you need to make paths absolute in helix settings 2. Use the correct compiler (set `RUSTC` and `CARGO` to stage0, instead of `RUSTUP_TOOLCHAIN=nightly`) 3. Add comments to vscode and zed settings NB: I only tested helix settings, but am pretty sure that the other changes shouldn't break anything.
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Rollup of 6 pull requests Successful merges: - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size) - #153413 (std: organise `sys::pal::os`) - #139692 (Rustfmt now support use closures) - #153244 (tools: remote-test-server: Add UEFI run support) - #153305 (Adapt codegen test to accept operand bundles) - #153340 (tweak r-a default settings)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for 4c82f61 failed: CI. Failed job:
|
Contributor
|
Spurious |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Rollup of 6 pull requests Successful merges: - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size) - #153413 (std: organise `sys::pal::os`) - #139692 (Rustfmt now support use closures) - #153244 (tools: remote-test-server: Add UEFI run support) - #153305 (Adapt codegen test to accept operand bundles) - #153340 (tweak r-a default settings)
Contributor
|
💔 Test for e13beef failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
Is this spurious again or is there a PR in here having a subtle effect somehow? |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Rollup of 6 pull requests try-job: dist-aarch64-apple try-job: dist-x86_64-apple
Contributor
|
@bors retry |
Contributor
|
Closing in favour of a bigger rollup: #153605 |
Contributor
|
This pull request was unapproved due to being closed. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
sys::pal::os#153413 (std: organisesys::pal::os)r? @ghost
Create a similar rollup