Skip to content

std: refactor Xous startup code#153341

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joboet:xous_params
Mar 4, 2026
Merged

std: refactor Xous startup code#153341
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joboet:xous_params

Conversation

@joboet
Copy link
Member

@joboet joboet commented Mar 3, 2026

To facilitate #117276 I'm moving all non-path-related code out of sys::pal::os (see also #153130). This is particularly involved for Xous as pal::os also contains the _start entry function and the parameter block handling. This PR moves both out into the main sys::pal module and also simplifies the parameter block initialisation code slightly.

CC @xobs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates

@xobs
Copy link
Contributor

xobs commented Mar 4, 2026

Thanks for this. The new location does seem like a better place for it.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 4, 2026

📌 Commit a598ccf has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 4, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026
Rollup of 5 pull requests

Successful merges:

 - #153341 (std: refactor Xous startup code)
 - #152816 (Check for region dependent goals on type_op itself as well)
 - #153224 (Fix LegacyKeyValueFormat report from docker build: disabled)
 - #153274 (Fix async drop multi crate crash)
 - #153324 (fix autodiff parsing for non-trait impl)
@rust-bors rust-bors bot merged commit d70f5bd into rust-lang:main Mar 4, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 4, 2026
rust-timer added a commit that referenced this pull request Mar 4, 2026
Rollup merge of #153341 - joboet:xous_params, r=tgross35

std: refactor Xous startup code

To facilitate #117276 I'm moving all non-path-related code out of `sys::pal::os` (see also #153130). This is particularly involved for Xous as `pal::os` also contains the `_start` entry function and the parameter block handling. This PR moves both out into the main `sys::pal` module and also simplifies the parameter block initialisation code slightly.

CC @xobs
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 9, 2026
…ulacrum

std: organise `sys::pal::os`

Continuing rust-lang#153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of rust-lang#117276).

Best reviewed commit-by-commit.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
…ulacrum

std: organise `sys::pal::os`

Continuing rust-lang#153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of rust-lang#117276).

Best reviewed commit-by-commit.
rust-timer added a commit that referenced this pull request Mar 9, 2026
Rollup merge of #153413 - joboet:organize-pal-os, r=Mark-Simulacrum

std: organise `sys::pal::os`

Continuing #153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of #117276).

Best reviewed commit-by-commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants