Rollup of 11 pull requests#153605
Conversation
Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below: 1. Use rust-lld linker: `bootstrap.toml` ```toml [rust] lld = true [target.x86_64-unknown-uefi] linker = "rust-lld" ``` 2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional. ```shell fs1: run.efi --sequential --bind "10.0.2.15:12345" --batch ``` 3. Launch remote-test-server in QEMU. I am using uefi-run script [0]. ```shell uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi -n --startup startup.nsh --tcp-port 12345 ``` 4. Run tests: ```shell RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1 ``` [0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run Signed-off-by: Ayush Singh <ayush@beagleboard.org>
… bound to __rust_alloc size LLVM emits a lower bound of 8 for the size parameter to __rust_alloc when targeting x86_64-unknown-hermit. Since that is also completely valid, relax the lower bound check.
1. Explain that you need to make paths absolute in helix settings 2. Use the correct compiler (set `RUSTC` and `CARGO` to stage0, instead of `RUSTUP_TOOLCHAIN=nightly`) 3. Add comments to vscode and zed settings
* Move dyn-drop to dyn-keyword * Reorganize `tests/ui/empty` into specific dirs remove tests/ui/empty/empty-linkname.rs duplicate of tests/ui/error-codes/E0454.rs * Move `missing-trait-bounds` to `trait-bound/missing-trait-bounds` * bless traits/missing-trait-bounds tests * Move `recursion_limit` to `recursion/recursion_limit` * Move `version` to `compile-flags`
…c_middle/src/mir/interpret/queries.rs`
…nline-test, r=Mark-Simulacrum Test for armv7 `get_unchecked(...)` inlining Added test for `get_unchecked(...)` to be inlined on armv7. closes rust-lang#131745
…op-lower-bound-hermit, r=Mark-Simulacrum tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size LLVM emits a lower bound of 8 for the size parameter to `__rust_alloc` when targeting `x86_64-unknown-hermit`. Since that is also completely valid, relax the lower bound check. I'm not really sure why LLVM is able to infer this - with the same setup targeting `x86_64-unknown-linux-gnu` I also see the lower bound of 0. Not that it's wrong, but I'd be curious to know which codegen options play into this.
…ulacrum std: organise `sys::pal::os` Continuing rust-lang#153341, this moves around some functions in `sys::pal`, so that `pal::os` only contains standard-path-related code (which I'll move later as part of rust-lang#117276). Best reviewed commit-by-commit.
…r=Mark-Simulacrum Rustfmt now support use closures This should be merged when rust-lang/rustfmt#6532 is used by CI's rustfmt.
Adds recursion limit into FindParamInClause Fixes rust-lang#152716 r? lcnr
…mulacrum tools: remote-test-server: Add UEFI run support Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below: 1. Use rust-lld linker: `bootstrap.toml` ```toml [rust] lld = true [target.x86_64-unknown-uefi] linker = "rust-lld" ``` 2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional. ```shell fs1: run.efi --sequential --bind "10.0.2.15:12345" --batch ``` 3. Launch remote-test-server in QEMU. I am using uefi-run script [0]. ```shell uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi -n --startup startup.nsh --tcp-port 12345 ``` 4. Run tests: ```shell RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1 ``` Requires: rust-lang#151014 @rustbot label +O-UEFI cc @nicholasbishop [0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run
…crum Adapt codegen test to accept operand bundles The updated test current fails when rustc is built with HEAD LLVM: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/44013/steps/canvas?sid=019cafec-3cca-44b2-aa9f-b41c0a940e8b Likely as a result of llvm/llvm-project#169923 Since the new codegen merges two lines into one, I couldn't figure out a way to make the test work on both LLVM versions without introducing revisions. (Though I could instead make the test run on only LLVM 23+). @rustbot label llvm-main
…=Mark-Simulacrum tweak r-a default settings 1. Explain that you need to make paths absolute in helix settings 2. Use the correct compiler (set `RUSTC` and `CARGO` to stage0, instead of `RUSTUP_TOOLCHAIN=nightly`) 3. Add comments to vscode and zed settings NB: I only tested helix settings, but am pretty sure that the other changes shouldn't break anything.
|
@bors r+ rollup=never p=5 |
|
Trying commonly failed jobs |
This comment has been minimized.
This comment has been minimized.
Rollup of 11 pull requests try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 655a7d2 (parent) -> 3945997 (this PR) Test differencesShow 168 test diffsStage 1
Stage 2
(and 56 additional test diffs) Additionally, 12 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3945997aabf6165261ef3419534c1ad59d9dc5c6 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 655a7d20fe In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (3945997): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 479.555s -> 480.086s (0.11%) |
Successful merges:
get_unchecked(...)inlining #152847 (Test for armv7get_unchecked(...)inlining)sys::pal::os#153413 (std: organisesys::pal::os)r? @ghost
Create a similar rollup