Merged
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
reddevilmidzy
commented
Mar 9, 2026
dd02187 to
e5e2cf5
Compare
JohnTitor
approved these changes
Mar 9, 2026
Member
|
Looks good! r=me once CI passes |
Member
|
not sure, but if you originally intended to squash commits, it's good time to do so |
Member
Author
|
@bors squash |
This comment has been minimized.
This comment has been minimized.
* Move dyn-drop to dyn-keyword * Reorganize `tests/ui/empty` into specific dirs remove tests/ui/empty/empty-linkname.rs duplicate of tests/ui/error-codes/E0454.rs * Move `missing-trait-bounds` to `trait-bound/missing-trait-bounds` * bless traits/missing-trait-bounds tests * Move `recursion_limit` to `recursion/recursion_limit` * Move `version` to `compile-flags`
Contributor
|
🔨 6 commits were squashed into e636647. |
e5e2cf5 to
e636647
Compare
Member
|
@bors r=JohnTitor,Kivooeo rollup |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152847 (Test for armv7 `get_unchecked(...)` inlining) - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size) - #153413 (std: organise `sys::pal::os`) - #139692 (Rustfmt now support use closures) - #152800 (Adds recursion limit into FindParamInClause) - #153244 (tools: remote-test-server: Add UEFI run support) - #153305 (Adapt codegen test to accept operand bundles) - #153340 (tweak r-a default settings) - #153509 (Cleanup unused diagnostic emission methods - part 2) - #153527 (Fix LegacyKeyValueFormat report from docker build: ohos) - #153594 (Move some ui tests)
rust-timer
added a commit
that referenced
this pull request
Mar 9, 2026
Rollup merge of #153594 - reddevilmidzy:ui-refactor, r=JohnTitor,Kivooeo Move some ui tests > [!NOTE] > I split the commits to make the review easier and to keep the git history easier to trace. Renamed issue-xxx tests `tests/ui/dyn-drop` -> `tests/ui/dyn-keyword` `tests/ui/missing-trait-bounds` -> `tests/ui/trait-bound/missing-trait-bounds` `tests/ui/recursion_limit` -> `tests/ui/recursion/recursion_limit` `tests/ui/version` -> `tests/ui/compile-flags` Reorganize `tests/ui/empty`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I split the commits to make the review easier and to keep the git history easier to trace.
Renamed issue-xxx tests
tests/ui/dyn-drop->tests/ui/dyn-keywordtests/ui/missing-trait-bounds->tests/ui/trait-bound/missing-trait-boundstests/ui/recursion_limit->tests/ui/recursion/recursion_limittests/ui/version->tests/ui/compile-flagsReorganize
tests/ui/empty