Skip to content

[crystal-backport] Backport XML and XSLT functionality#93

Merged
mjcarroll merged 71 commits intocrystalfrom
master
Mar 8, 2019
Merged

[crystal-backport] Backport XML and XSLT functionality#93
mjcarroll merged 71 commits intocrystalfrom
master

Conversation

@mjcarroll
Copy link
Copy Markdown
Member

@mjcarroll mjcarroll commented Mar 8, 2019 •
edited
Loading

Based on discussion in #81 and #79, we can backport this new functionality into Crystal.

  • Introduces using XML for the policy file format.
    • Also introduces a dependency on lxml, which is available via apt or pip, depending on the platform.

This backport includes:

ruffsl added 30 commits February 21, 2019 10:56
@ruffsl
Add example xml profile and transform
ea198c0 
This profile is language agnostic, and transforms can be added for more transports
@ruffsl
Move template files
3e8a1da
@ruffsl
Rename to be plural
3e0aaa7
@ruffsl
Add dds permissions schema
1088ad6
@ruffsl
Leverage namespacing
5b7d075
@ruffsl
Add nested root node and version attribute to future proof
bf769f0
@ruffsl
Using .xsl extension
8cf6454
@ruffsl
Add XSD schema for profile xml files
fc6ccc5
@ruffsl
Include package data for profiles xml
1fd7a6d
@ruffsl
Clear up terminology
137b4ed 
policy is a collection of profiles
@ruffsl
rename folders
440eb77
@ruffsl
Declare python3-lxml dependably
77b6036
@ruffsl
Fix setup script
68c6568
@ruffsl
Change template to be more simpler with previous template
13f771b
@ruffsl
Update example
498e2cf
@ruffsl
Change get_policy to use xml
172b0d8
@ruffsl
Start adding test cases
01481ad
@ruffsl
Update readme
cda8974
@ruffsl
Correct spelling
4142ee2
@ruffsl
Rework example to use sros2 package data
13f90f9
@ruffsl
Rename example script
9b640e8
@ruffsl
Refactor governace defaults to use template xml
069cf40
@ruffsl
Use default policy
dfbd85c
@ruffsl
Add missing governace schema
e66a48e
@ruffsl
Change default domain id type from int to string
aec3d3a
@ruffsl
Add support for Relative, Global, and Private namespaces
0b0f3d0
@ruffsl
Linter
99b6333
@ruffsl
Refactor main permission loops
01f2af1 
fixes duplicate output when multiple rule types are under the same profile
@ruffsl
Ensure Common Name is distinct
ababf3f 
by using the complete FQN of the node
@ruffsl
Normilize relative path
7570c46
ruffsl and others added 23 commits February 21, 2019 11:00
@ruffsl
Fix linter
8aea291
@ruffsl
Strip white spaces
3a7a640
@ruffsl
Add template to alphabetize policy elements and sort profiles by name…
d741012 
…space
@ruffsl
Update tests for new stylesheet
1412846
@ruffsl
Refactor policy generation to use new xml format
713baa0
@ruffsl
Add defaults folder to extra files
c848387
@ruffsl
Update example on downloading sample policy
427f6f5
@ruffsl
Relax minOccurs to allow for empty profiles
b954b29 
for when generate_policies doesn't necessarily add permissions to a generated profile.
@ruffsl
Account for root level topics when ns is already root
6169867
@ruffsl
Remove unnecessary IO import
b88da17
@ruffsl
Ensure key name is fqn
e0f6831
@ruffsl
start profile version at initial development release 0.1.0
11ad8c9
@ruffsl
Patch request permission for Crystal
c9a682f 
Crystal seems to require permission for parameters though is should be unnecessary
@mikaelarguedas @ruffsl
add logging profile to publish to rosout
416a1e4
@mikaelarguedas @ruffsl
update test with rosout
4018923
@mikaelarguedas @ruffsl
make rosout relative
f2fe5aa 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Merge pull request #72 from ros2/xml_profile
79fffad 
Use XML and XSLT to perform permission transform
@ruffsl
Correct sros2 cli test folder location (#83)
d419f7b 
* Update test folder location
fixing incomplete rebase from #72

* Remove old yaml profile examples
fixing incomplete rebase from #72
@mikaelarguedas
add reference to schema in generated permission files (#84)
dace0b5 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@jacobperron
Add missing attributes to test permissions XML file
8165d7f 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@mikaelarguedas @jacobperron
fix status print to match commands invoked
681dd34 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@jacobperron
Fix bug preventing generate_policy verb from working with publishers …
f1f9e24 
…and services

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add CMake lint test to sros2_cmake (#90)
c59ea2f 
Fixed lint errors accordingly.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Mar 8, 2019
@nuclearsandwich nuclearsandwich mentioned this pull request Mar 8, 2019
Closed
10 tasks
@mjcarroll
Copy link
Copy Markdown
Member Author

mjcarroll commented Mar 8, 2019

This reveals that I clearly didn't squash-merge something in the past that I should have 😬

@mjcarroll mjcarroll merged commit aafc86d into crystal Mar 8, 2019
@mjcarroll mjcarroll removed the in progress Actively being worked on (Kanban column) label Mar 8, 2019
@jacobperron jacobperron mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjcarroll @jacobperron @ruffsl @mikaelarguedas