Add missing attributes to test permissions XML file#88
Merged
jacobperron merged 1 commit intomasterfrom Feb 26, 2019
Merged
Conversation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
CI (up to sros2):
|
mjcarroll
approved these changes
Feb 26, 2019
Member
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM with Green CI, thanks @jacobperron for getting this so quickly.
Member
|
Seems we forgot to update the test example after updating the schema in #84 like we did for #80 . Still might want to use difflib to report a more readable test error in how the generated files differ. https://docs.python.org/3.6/library/difflib.html E.g def display_diff_markdown(a, b, fromfile, tofile, n=4, lineterm=''):
aa = a.splitlines()
bb = b.splitlines()
diffs = difflib.unified_diff(a=aa, b=bb, fromfile=fromfile, tofile=tofile, n=n, lineterm=lineterm)
diff = '\n'.join(diffs)
display(Markdown('``` diff\n' + diff + '\n```'))
display_diff_markdown(a=actual_str,
b=expected_str,
fromfile='actual',
tofile='expected') |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #87