add logging permission profile#80
Merged
ruffsl merged 3 commits intoros2:xml_profilefrom Feb 21, 2019
Merged
Conversation
Member
|
Ah man... its like ROS1 all over again. Why is everything is needing to publish to root level topics and parameters by default. The test case may need to be updated though: https://github.com/ros2/sros2/pull/72/files#diff-9534083787043b52ef6d287331dfc69bR53 |
ruffsl
reviewed
Feb 18, 2019
Member
Author
Good point 👍, test updated in e385cbd |
This was referenced Feb 18, 2019
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Member
|
Ignore unrelated test failures in
Edit: Retriggering with ros2/ci#246 (which I think is required) |
Member
|
Looks like the changes in ros2/ci#246 need to be rebased on master, I'll just wait until it is merged before triggering CI. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets #72, not master
Since ros2/rcl#350 all node need publish access to
/rosoutby default.I called it logging in case we have other related default logging topics in the future.
@ruffsl FYI