[ros2_cmake] fix status print to match commands invoked#85
Merged
jacobperron merged 1 commit intoros2:masterfrom Mar 4, 2019
Merged
[ros2_cmake] fix status print to match commands invoked#85jacobperron merged 1 commit intoros2:masterfrom
jacobperron merged 1 commit intoros2:masterfrom
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
jacobperron
approved these changes
Mar 4, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
LGTM.
+1 for adding linters.
- Linux
- Linux-aarch64
- macOS
- Windows
Member
|
Added lint test in #90. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status message printed for
create_keydoes not match the command actually ran (additional${policy}argument making the command fail withros2: error: unrecognized arguments: foo.xml.)This PR uses the same string for the command and the message to avoid discrepancies in the future
The style of this file doesn't seem to match the ROS 2 style guide for CMake. @mjcarroll @ross-desmond could we add linters to this package?