Fix bug preventing generate_policy verb from working with publishers and services#91
Merged
jacobperron merged 1 commit intomasterfrom Mar 5, 2019
Merged
Fix bug preventing generate_policy verb from working with publishers and services#91jacobperron merged 1 commit intomasterfrom
jacobperron merged 1 commit intomasterfrom
Conversation
…and services Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
ruffsl
approved these changes
Mar 5, 2019
Member
There was a problem hiding this comment.
This bugfix solves the relative missing permissions described in #89 . Although, there doesn't seem a way for rosgraph API to return the service names a node would need request access for. I.e. current node in crystal require some overzealous permissions for request access to local parameter services hosted. This may be a separate issue.
Member
Author
Sounds like a separate issue; feel free to open a ticket. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #89