Skip to content

Hardcoded typesupport for Fibonacci action#47

Merged
sloretz merged 16 commits intomasterfrom
sloretz/fibonacci_action
Nov 9, 2018
Merged

Hardcoded typesupport for Fibonacci action#47
sloretz merged 16 commits intomasterfrom
sloretz/fibonacci_action

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Oct 30, 2018 •
edited
Loading

Split from #44. This PR has hardcoded type support classes for a Fibonacci action.

requires #44

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Oct 30, 2018
@sloretz sloretz mentioned this pull request Oct 31, 2018
Merged
@sloretz sloretz self-assigned this Oct 31, 2018
This was referenced Oct 31, 2018
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
@sloretz sloretz changed the base branch from sloretz/msg_srv_in_action to master November 1, 2018 18:48
hidmic
hidmic approved these changes Nov 2, 2018
View reviewed changes
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get this going.

test_msgs/include/test_msgs/action/fibonacci.h Outdated
}
#endif

#define TEST_MSGS__ACTION__FIBONACCI_H_
Copy link
Copy Markdown

@hidmic hidmic Nov 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloretz #endif // TEST_MSGS__ACTION__FIBONACCI_H_ ?

Copy link
Copy Markdown
Contributor Author

@sloretz sloretz Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f99efcf

@hidmic
Copy link
Copy Markdown

hidmic commented Nov 2, 2018

Also, it looks like this branch could use a rebase.

@sloretz sloretz force-pushed the sloretz/fibonacci_action branch from 780b462 to 1964b1d Compare November 2, 2018 13:59
@hidmic hidmic mentioned this pull request Nov 2, 2018
Merged
@sloretz sloretz mentioned this pull request Nov 2, 2018
Merged
jacobperron
jacobperron approved these changes Nov 8, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment from @hidmic, this looks good to go 👍

@jacobperron jacobperron mentioned this pull request Nov 8, 2018
Merged
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 8, 2018 •
edited
Loading

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

PRs in CI

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 9, 2018

Checking if Windows dll linkage issue is fixed by a4dfb38

Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 9, 2018

Checking if WIndows dll linkage issue is fixed by 6d6da58

Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 9, 2018 •
edited
Loading

Rerunning full CI now that windows linker issue is fixed

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 9, 2018
@hidmic
Copy link
Copy Markdown

hidmic commented Nov 9, 2018

@sloretz looks like this is ready!!

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 9, 2018

@hidmic I think it's ready. All that is left is for ros2/rosidl_python#17 and ros2/rosidl#310 to pass code review and possibly another round of CI after fixing issues found during their reviews.

@sloretz sloretz merged commit 6cff4c3 into master Nov 9, 2018
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Nov 9, 2018
@sloretz sloretz deleted the sloretz/fibonacci_action branch November 9, 2018 22:07
@mjcarroll
Copy link
Copy Markdown
Member

mjcarroll commented Nov 12, 2018

@sloretz This appears to break test_msgs on:

10:12:19 Undefined symbols for architecture x86_64:
10:12:19   "_rosidl_typesupport_opensplice_c__get_message_type_support_handle__test_msgs__srv__Fibonacci_Goal_Request", referenced from:
10:12:19       _send_request__action__Fibonacci_Goal in fibonacci__goal__type_support_c.cpp.o
10:12:19       _take_request__action__Fibonacci_Goal in fibonacci__goal__type_support_c.cpp.o
10:12:19   "_rosidl_typesupport_opensplice_c__get_message_type_support_handle__test_msgs__srv__Fibonacci_Goal_Response", referenced from:
10:12:19       _send_response__action__Fibonacci_Goal in fibonacci__goal__type_support_c.cpp.o
10:12:19       _take_response__action__Fibonacci_Goal in fibonacci__goal__type_support_c.cpp.o
10:12:19   "_rosidl_typesupport_opensplice_c__get_message_type_support_handle__test_msgs__srv__Fibonacci_Result_Request", referenced from:
10:12:19       _send_request__action__Fibonacci_Result in fibonacci__result__type_support_c.cpp.o
10:12:19       _take_request__action__Fibonacci_Result in fibonacci__result__type_support_c.cpp.o
10:12:19   "_rosidl_typesupport_opensplice_c__get_message_type_support_handle__test_msgs__srv__Fibonacci_Result_Response", referenced from:
10:12:19       _send_response__action__Fibonacci_Result in fibonacci__result__type_support_c.cpp.o
10:12:19       _take_response__action__Fibonacci_Result in fibonacci__result__type_support_c.cpp.o
10:12:19 ld: symbol(s) not found for architecture x86_64

@sloretz sloretz mentioned this pull request Nov 12, 2018
Merged
dirk-thomas pushed a commit to ros2/test_interface_files that referenced this pull request Jan 18, 2019
@sloretz
Hardcoded typesupport for Fibonacci action (ros2/rcl_interfaces#47)
18bedba 
* msg and srv in actions folder

* Add uniquely named messages and services

* Add hand made action typesupport

* respose -> result request

* respose -> response

* Use goal info in more places

* Fix feedback symbol

* Generate from .action file

* Hardcoded typesupport works with generated msg and srv

* C typesupport returns rcl_action_type_support_t

* Function to get typsupport struct from C++ typesupport

* rosidl_typesupport_cpp namespace

* Fix include guard

* Fix linter test failures

* Fix dll linkage on Windows

* Fix windows linking issue by having separate visibility macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

@hidmic hidmic hidmic approved these changes

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sloretz @hidmic @mjcarroll @jacobperron