Closed
Conversation
4cbb5b2 to
3a6ee6a
Compare
jacobperron
reviewed
Oct 25, 2018
Member
jacobperron
left a comment
There was a problem hiding this comment.
Some minor comments. The rest LGTM.
hidmic
reviewed
Oct 26, 2018
6a22042 to
d94b6fa
Compare
Contributor
Author
|
Closing. This was useful for testing the PRs undier ros2/rosidl#301, but doesn't serve a purpose now that #47 is up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds messages and services in an action folder
connects to ros2/rosidl#301