Skip to content

Allow generated IDL files#45

Merged
sloretz merged 1 commit intomasterfrom
sloretz/allow_generated_idl
Nov 9, 2018
Merged

Allow generated IDL files#45
sloretz merged 1 commit intomasterfrom
sloretz/allow_generated_idl

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Oct 31, 2018

The target dependency won't exist at cmake configure time before the first build if it is generated, so don't FATAL_ERROR in that case.

connects to ros2/rcl_interfaces#47

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Oct 31, 2018
@sloretz sloretz self-assigned this Oct 31, 2018
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloretz sloretz merged commit 1278043 into master Nov 9, 2018
@sloretz sloretz deleted the sloretz/allow_generated_idl branch November 9, 2018 22:07
@sloretz sloretz removed the in progress Actively being worked on (Kanban column) label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants