Conversation
Since the custom command is in a subdirectory it cannot depend on the generated files directly. Instead it depends on a target from the parent directory which depends on the IDL files.
Member
|
Needs a rebase on master. |
Since the custom command is in a subdirectory it cannot depend on the generated files directly. Instead it depends on a target from the parent directory which depends on the IDL files.
b23bc68 to
47e369b
Compare
…/rosidl_python into sloretz/allow_generated_idl
hidmic
reviewed
Nov 9, 2018
Contributor
hidmic
left a comment
There was a problem hiding this comment.
LGTM! Though I think it'd be good for our future selves to add a comment with an explanation for the rationale behind this change.
Contributor
Author
jacobperron
approved these changes
Nov 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target dependency won't exist at cmake configure time before the first build if it is generated. Since the custom command is in a subdirectory it cannot depend on the generated files directly. Instead it depends on a target from the parent directory which depends on the IDL files.
connects to ros2/rcl_interfaces#47