Generate messages and services from actions#310
Merged
Conversation
Contributor
|
@sloretz this PR needs a rebase :) |
6651f09 to
a523011
Compare
Merged
hidmic
reviewed
Nov 2, 2018
Contributor
hidmic
left a comment
There was a problem hiding this comment.
I believe this PR needs a rebase. It'll hopefully get rid of the commits you built on top of.
| set(_action_files ${_ARG_UNPARSED_ARGUMENTS}) | ||
|
|
||
| # Make a list of files that will be generated | ||
| set(_output_path "${CMAKE_CURRENT_BINARY_DIR}/action_msg_and_srv/${PROJECT_NAME}") |
Contributor
There was a problem hiding this comment.
@sloretz why not generating these messages below ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}/${_parent_folder} where _parent_folder == 'action'?
Contributor
Author
There was a problem hiding this comment.
In 18d40bb changed action_msg_and_srv to the name of the package the code doing the conversion is in: rosidl_actions. This matches the C and C++ generators.
| const rosidl_message_type_support_t * status_message_type_support; | ||
| }; | ||
|
|
||
| #define ROSIDL_GET_ACTION_TYPE_SUPPORT(PkgName, Subfolder, Name) \ |
c3f77e9 to
8619ae1
Compare
Contributor
c2556f4 to
38646b7
Compare
5876c98 to
cd2f5ac
Compare
26ed532 to
774f516
Compare
jacobperron
approved these changes
Nov 9, 2018
Member
jacobperron
left a comment
There was a problem hiding this comment.
LGTM and appears to be working for ros2/rcl#323 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the cmake plumbing to generate code for actions. It converts
.actionfiles passed torosidl_generate_interfaces()to.msgand.srv, then passes those through the normal generation pipeline with the other.msgand.srvpassed.It does not generate typesupport files for the
.actionthemselves. A proposal for those is hardcoded in ros2/rcl_interfaces#47.Requires #311
connects to ros2/rcl_interfaces#47