feat(napi): add `aarch64-linux-android` target by Boshen · Pull Request #5141 · rolldown/rolldown

Boshen · 2025-07-02T07:20:23Z

Boshen · 2025-07-02T07:20:37Z

feat(napi): add aarch64-linux-android target #5141 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-07-02T07:21:10Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`abdc470`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6871fb9b8fc81e0008846e06

IWANABETHATGUY · 2025-07-02T07:24:21Z

It seems you also need to create an extra package under packages/rolldown/npm

Boshen · 2025-07-02T08:53:22Z

@Brooooooklyn can you help out and clean up the need for a packages/rolldown/npm directory? It's redundant.

Brooooooklyn · 2025-07-02T08:58:29Z

I don't understand why these dependencies are needed: https://github.com/rolldown/rolldown/blob/main/packages/rolldown/package.json#L180-L191

The packages/rolldown/npm directory is not required if there are no optionalDependencies present

Boshen · 2025-07-02T09:46:06Z

I don't understand why these dependencies are needed: https://github.com/rolldown/rolldown/blob/main/packages/rolldown/package.json#L180-L191

The packages/rolldown/npm directory is not required if there are no optionalDependencies present

That's why I'm asking you to clean it up 😅 It's a bit confusing right now.

hyf0 · 2025-07-02T20:36:14Z

I don't understand why these dependencies are needed: https://github.com/rolldown/rolldown/blob/main/packages/rolldown/package.json#L180-L191

The packages/rolldown/npm directory is not required if there are no optionalDependencies present

Here's the reason: #654.

pkg-pr-new · 2025-07-11T04:09:21Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@5141

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@5141

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@5141

rolldown

npm i https://pkg.pr.new/rolldown@5141

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@5141

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@5141

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@5141

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@5141

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@5141

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@5141

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@5141

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@5141

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@5141

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@5141

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@5141

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@5141

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@5141

commit: d3c250b

graphite-app · 2025-07-11T06:06:15Z

Merge activity

Jul 11, 6:06 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Jul 11, 6:06 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
Jul 11, 6:06 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Jul 11, 6:06 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
Jul 11, 6:08 AM UTC: Graphite disabled "merge when ready" on this PR due to: Unknown error.

closes #4560

@Brooooooklyn

## [1.0.0-beta.27] - 2025-07-13 ### 🚀 Features - rolldown: support linux-arm64-ohos (#5258) by @Brooooooklyn - napi: add `aarch64-linux-android` target (#5141) by @Boshen - rolldown: oxc v0.77.0 (#5255) by @Boshen ### 🐛 Bug Fixes - `this` in CJS is replaced with undefined but should be `exports` (#5244) by @IWANABETHATGUY - normalize path from package.json's realpath before matching sideEffects field (#5250) by @sapphi-red ### ⚡ Performance - don't wrap module if it is leaf module and side effects free when enable `strictExecutionOrder` (#5240) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - upgrade NAPI-RS cli to 3.0.0-alpha.93 (#5243) by @Brooooooklyn Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

Boshen requested a review from Brooooooklyn July 2, 2025 08:52

Boshen assigned Brooooooklyn Jul 2, 2025

Boshen marked this pull request as draft July 2, 2025 08:53

Brooooooklyn force-pushed the 07-02-feat_napi_add_aarch64-linux-android_target branch from fe74e55 to 99f7baf Compare July 11, 2025 03:38

Brooooooklyn added trigger: preview and removed trigger: preview labels Jul 11, 2025

Brooooooklyn force-pushed the 07-02-feat_napi_add_aarch64-linux-android_target branch from 53f476a to 46684ed Compare July 11, 2025 08:12

Brooooooklyn added trigger: preview and removed trigger: preview labels Jul 11, 2025

Brooooooklyn force-pushed the 07-02-feat_napi_add_aarch64-linux-android_target branch from 3e5c505 to 42763b3 Compare July 11, 2025 09:43

Brooooooklyn added trigger: preview and removed trigger: preview labels Jul 11, 2025

Brooooooklyn force-pushed the 07-02-feat_napi_add_aarch64-linux-android_target branch from 42763b3 to 8874420 Compare July 11, 2025 09:59

Brooooooklyn added trigger: preview and removed trigger: preview labels Jul 11, 2025

Brooooooklyn force-pushed the 07-02-feat_napi_add_aarch64-linux-android_target branch from 4ef8a5c to d3c250b Compare July 12, 2025 02:15

Brooooooklyn added trigger: preview and removed trigger: preview labels Jul 12, 2025

Brooooooklyn marked this pull request as ready for review July 12, 2025 06:05

Boshen and others added 8 commits July 12, 2025 14:05

feat(napi): add aarch64-linux-android target

e4d5e70

closes #4560

remove useless npm dirs and optionalDependencies

50be729

knip

4706136

artifacts

545d174

pre-publish only

53de153

--skip-optional-publish

a35a911

update cli

cb45ed7

dedupe lock

abdc470

Brooooooklyn force-pushed the 07-02-feat_napi_add_aarch64-linux-android_target branch from ce29359 to abdc470 Compare July 12, 2025 06:07

Brooooooklyn approved these changes Jul 12, 2025

View reviewed changes

hyf0 approved these changes Jul 12, 2025

View reviewed changes

Brooooooklyn added this pull request to the merge queue Jul 12, 2025

Merged via the queue into main with commit ffa4212 Jul 12, 2025
41 checks passed

Brooooooklyn deleted the 07-02-feat_napi_add_aarch64-linux-android_target branch July 12, 2025 06:52

github-actions bot mentioned this pull request Jul 13, 2025

release: v1.0.0-beta.27 #5263

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(napi): add `aarch64-linux-android` target#5141

feat(napi): add `aarch64-linux-android` target#5141
Brooooooklyn merged 8 commits intomainfrom
07-02-feat_napi_add_aarch64-linux-android_target

Boshen commented Jul 2, 2025

Uh oh!

Boshen commented Jul 2, 2025

Uh oh!

netlify bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Jul 2, 2025

Uh oh!

Boshen commented Jul 2, 2025 •

edited

Loading

Uh oh!

Brooooooklyn commented Jul 2, 2025

Uh oh!

Boshen commented Jul 2, 2025

Uh oh!

hyf0 commented Jul 2, 2025

Uh oh!

pkg-pr-new bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Boshen commented Jul 2, 2025

Uh oh!

Boshen commented Jul 2, 2025

Uh oh!

netlify bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

IWANABETHATGUY commented Jul 2, 2025

Uh oh!

Boshen commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Brooooooklyn commented Jul 2, 2025

Uh oh!

Boshen commented Jul 2, 2025

Uh oh!

hyf0 commented Jul 2, 2025

Uh oh!

pkg-pr-new bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Jul 2, 2025 •

edited

Loading

Boshen commented Jul 2, 2025 •

edited

Loading

pkg-pr-new bot commented Jul 11, 2025 •

edited

Loading

graphite-app bot commented Jul 11, 2025 •

edited

Loading