Skip to content

fix: this in CJS is replaced with undefined but should be exports#5244

Merged
IWANABETHATGUY merged 1 commit intomainfrom
07-10-fix_5242
Jul 11, 2025
Merged

fix: this in CJS is replaced with undefined but should be exports#5244
IWANABETHATGUY merged 1 commit intomainfrom
07-10-fix_5242

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jul 10, 2025 •
edited
Loading

Closed #5242

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jul 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit aa4d089
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6871309550fec300081daa7d

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 10, 2025 14:31
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     82.6±4.15ms        ? ?/sec    1.00     81.1±3.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     91.9±3.84ms        ? ?/sec    1.00     92.1±3.69ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    117.8±3.75ms        ? ?/sec    1.00    117.0±3.53ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.8±3.39ms        ? ?/sec    1.00    139.0±2.87ms        ? ?/sec
bundle/bundle@threejs                                        1.05     44.7±1.64ms        ? ?/sec    1.00     42.5±1.14ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.8±3.01ms        ? ?/sec    1.01     53.4±0.95ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   459.3±10.39ms        ? ?/sec    1.00    452.9±7.48ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    533.0±8.74ms        ? ?/sec    1.00    526.5±9.07ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.0±3.24ms        ? ?/sec    1.01     92.7±2.68ms        ? ?/sec
scan/scan@threejs                                            1.00     32.3±0.68ms        ? ?/sec    1.01     32.7±0.57ms        ? ?/sec
scan/scan@threejs10x                                         1.00    338.2±7.02ms        ? ?/sec    1.00    339.0±6.17ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 5242 fix: this in CJS is replaced with undefined but should be module.exports Jul 10, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: this in CJS is replaced with undefined but should be module.exports fix: this in CJS is replaced with undefined but should be exports Jul 10, 2025
hyf0
hyf0 reviewed Jul 10, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit 5df6abb Jul 11, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-10-fix_5242 branch July 11, 2025 15:55
@github-actions github-actions bot mentioned this pull request Jul 13, 2025
Merged
shulaoda added a commit that referenced this pull request Jul 13, 2025
@github-actions @shulaoda
release: v1.0.0-beta.27 (#5263)
50e5154 
## [1.0.0-beta.27] - 2025-07-13

### 🚀 Features

- rolldown: support linux-arm64-ohos (#5258) by @Brooooooklyn
- napi: add `aarch64-linux-android` target (#5141) by @Boshen
- rolldown: oxc v0.77.0 (#5255) by @Boshen

### 🐛 Bug Fixes

- `this` in CJS is replaced with undefined but should be `exports`
(#5244) by @IWANABETHATGUY
- normalize path from package.json's realpath before matching
sideEffects field (#5250) by @sapphi-red

### ⚡ Performance

- don't wrap module if it is leaf module and side effects free when
enable `strictExecutionOrder` (#5240) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- upgrade NAPI-RS cli to 3.0.0-alpha.93 (#5243) by @Brooooooklyn

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: this in CJS is replaced with undefined but should be module.exports

2 participants

@IWANABETHATGUY @hyf0