Skip to content

fix: normalize path from package.json's realpath before matching sideEffects field#5250

Merged
sapphi-red merged 1 commit intomainfrom
07-11-fix_normalize_path_from_package.json_s_realpath_before_matching_sideeffects_field
Jul 11, 2025
Merged

fix: normalize path from package.json's realpath before matching sideEffects field#5250
sapphi-red merged 1 commit intomainfrom
07-11-fix_normalize_path_from_package.json_s_realpath_before_matching_sideeffects_field

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 11, 2025 •
edited by shulaoda
Loading

@sapphi-red @shulaoda
fix: normalize path from package.json's realpath before matching side…
cd7226c 
…Effects field

Co-Authored-By: shulaoda <165626830+shulaoda@users.noreply.github.com>
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Jul 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review July 11, 2025 05:33
@netlify
Copy link

netlify bot commented Jul 11, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit cd7226c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6870a21b479c570008678c25
😎 Deploy Preview https://deploy-preview-5250--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sapphi-red sapphi-red mentioned this pull request Jul 11, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Benchmarks Rust

  • target: main(79d6dc7)
  • pr: 07-11-fix_normalize_path_from_package.json_s_realpath_before_matching_sideeffects_field(cd7226c)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     80.1±2.15ms        ? ?/sec    1.00     77.4±2.50ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     92.1±3.84ms        ? ?/sec    1.00     90.9±4.61ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    116.5±3.51ms        ? ?/sec    1.00    113.1±1.41ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    135.7±1.98ms        ? ?/sec    1.00    133.9±1.64ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.0±2.41ms        ? ?/sec    1.00     42.1±2.24ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.0±1.31ms        ? ?/sec    1.00     51.0±1.38ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    444.8±5.23ms        ? ?/sec    1.00    438.6±3.56ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    519.7±6.16ms        ? ?/sec    1.00    511.6±4.34ms        ? ?/sec
scan/scan@rome_ts                                            1.02     90.0±1.78ms        ? ?/sec    1.00     88.3±2.02ms        ? ?/sec
scan/scan@threejs                                            1.03     32.1±2.28ms        ? ?/sec    1.00     31.2±1.81ms        ? ?/sec
scan/scan@threejs10x                                         1.03    338.0±4.18ms        ? ?/sec    1.00    327.0±4.60ms        ? ?/sec

@sapphi-red sapphi-red added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit ba12fc8 Jul 11, 2025
26 checks passed
@sapphi-red sapphi-red deleted the 07-11-fix_normalize_path_from_package.json_s_realpath_before_matching_sideeffects_field branch July 11, 2025 05:59
@github-actions github-actions bot mentioned this pull request Jul 13, 2025
Merged
shulaoda added a commit that referenced this pull request Jul 13, 2025
@github-actions @shulaoda
release: v1.0.0-beta.27 (#5263)
50e5154 
## [1.0.0-beta.27] - 2025-07-13

### 🚀 Features

- rolldown: support linux-arm64-ohos (#5258) by @Brooooooklyn
- napi: add `aarch64-linux-android` target (#5141) by @Boshen
- rolldown: oxc v0.77.0 (#5255) by @Boshen

### 🐛 Bug Fixes

- `this` in CJS is replaced with undefined but should be `exports`
(#5244) by @IWANABETHATGUY
- normalize path from package.json's realpath before matching
sideEffects field (#5250) by @sapphi-red

### ⚡ Performance

- don't wrap module if it is leaf module and side effects free when
enable `strictExecutionOrder` (#5240) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- upgrade NAPI-RS cli to 3.0.0-alpha.93 (#5243) by @Brooooooklyn

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pnpm monorepo project, ElementPlus css is missing when enableNativePlugin in production

2 participants

@sapphi-red @shulaoda