Skip to content

perf: don't wrap module if it is leaf module and side effects free when enable strictExecutionOrder#5240

Merged
IWANABETHATGUY merged 1 commit intomainfrom
07-10-feat_don_t_wrap_module_if_it_is_leaf_module_and_side_effects_free
Jul 10, 2025
Merged

perf: don't wrap module if it is leaf module and side effects free when enable strictExecutionOrder#5240
IWANABETHATGUY merged 1 commit intomainfrom
07-10-feat_don_t_wrap_module_if_it_is_leaf_module_and_side_effects_free

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jul 10, 2025 •
edited by hyf0
Loading

Continue #4686.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 10, 2025 09:22
@netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 77d1bde
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686fc3f2721d7900085d36d2

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jul 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title feat: don't wrap module if it is leaf module and side effects free perf: don't wrap module if it is leaf module and side effects free when enable strictExecutionOrder Jul 10, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-10-feat_don_t_wrap_module_if_it_is_leaf_module_and_side_effects_free branch from 3a30acd to 4eefb23 Compare July 10, 2025 09:26
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(9111a72)
  • pr: 07-10-feat_don_t_wrap_module_if_it_is_leaf_module_and_side_effects_free(77d1bde)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     84.5±2.33ms        ? ?/sec    1.01     85.6±2.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     95.6±1.88ms        ? ?/sec    1.05    100.0±3.37ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    120.8±2.75ms        ? ?/sec    1.02    123.2±2.73ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    141.3±2.09ms        ? ?/sec    1.02    144.3±2.34ms        ? ?/sec
bundle/bundle@threejs                                        1.03     47.1±3.00ms        ? ?/sec    1.00     45.9±2.48ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     54.1±2.75ms        ? ?/sec    1.02     55.1±0.97ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    468.6±7.82ms        ? ?/sec    1.00    469.6±4.71ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    552.4±9.60ms        ? ?/sec    1.00    549.0±6.84ms        ? ?/sec
scan/scan@rome_ts                                            1.00     93.7±2.37ms        ? ?/sec    1.06     99.4±2.98ms        ? ?/sec
scan/scan@threejs                                            1.00     32.6±0.43ms        ? ?/sec    1.04     33.8±2.04ms        ? ?/sec
scan/scan@threejs10x                                         1.00    341.5±3.67ms        ? ?/sec    1.02    348.2±4.60ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 July 10, 2025 13:45
@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-10-feat_don_t_wrap_module_if_it_is_leaf_module_and_side_effects_free branch from 4eefb23 to 77d1bde Compare July 10, 2025 13:45
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 79d6dc7 Jul 10, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-10-feat_don_t_wrap_module_if_it_is_leaf_module_and_side_effects_free branch July 10, 2025 15:31
@github-actions github-actions bot mentioned this pull request Jul 13, 2025
Merged
shulaoda added a commit that referenced this pull request Jul 13, 2025
@github-actions @shulaoda
release: v1.0.0-beta.27 (#5263)
50e5154 
## [1.0.0-beta.27] - 2025-07-13

### 🚀 Features

- rolldown: support linux-arm64-ohos (#5258) by @Brooooooklyn
- napi: add `aarch64-linux-android` target (#5141) by @Boshen
- rolldown: oxc v0.77.0 (#5255) by @Boshen

### 🐛 Bug Fixes

- `this` in CJS is replaced with undefined but should be `exports`
(#5244) by @IWANABETHATGUY
- normalize path from package.json's realpath before matching
sideEffects field (#5250) by @sapphi-red

### ⚡ Performance

- don't wrap module if it is leaf module and side effects free when
enable `strictExecutionOrder` (#5240) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- upgrade NAPI-RS cli to 3.0.0-alpha.93 (#5243) by @Brooooooklyn

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
@sapphi-red sapphi-red mentioned this pull request Jul 16, 2025
Closed
@PointSingularity PointSingularity mentioned this pull request Jul 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0