Skip to content

chore(node): hard code @rolldown/binding-... in optionalDependencies#654

Merged
hyf0 merged 1 commit intomainfrom
03-25-chore_node_hard_code_rolldown_binding-._in_optionaldependencies_
Mar 25, 2024
Merged

chore(node): hard code @rolldown/binding-... in optionalDependencies#654
hyf0 merged 1 commit intomainfrom
03-25-chore_node_hard_code_rolldown_binding-._in_optionaldependencies_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Mar 25, 2024

Description

napi pre-publish will create github release under the hood. It's not easy to config it depend on if we want release nightly or not.

context:

  • napi pre-publish will create npm folder in place folder and attach correct dependencies to package.json#optionalDependencies.

Test Plan


@hyf0 hyf0 marked this pull request as ready for review March 25, 2024 01:19
Copy link
Member Author

hyf0 commented Mar 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4d6d046
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6600d109da8f24000876f3cb

@hyf0 hyf0 merged commit 862ce3a into main Mar 25, 2024
@hyf0 hyf0 deleted the 03-25-chore_node_hard_code_rolldown_binding-._in_optionaldependencies_ branch March 25, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant