Skip to content

Conversation

@radumg
Copy link
Owner

@radumg radumg commented Jan 8, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

aparajit-pratap and others added 30 commits April 6, 2018 16:24
* update tests for List.Rank

* Update failing tests (#8663)

* update tests

* fix nested dictionary preview

* minor argument refactor

* add test
Reverting public API signature changes made in #8734
…ss to methods here, and they return promises.
review comments
swtich registration of js object to async version
Update librarie.min.js & decode search text
* POC

* Cleanup code.

* Add command line option -g for generating geometry json file.

* Remove filtering

* Fix node state flags at load time.

* Use UpdateValue for setting isVisible on node model. Revert set to private.

* Remove filtering.

* Clean up holder code.

* Cleanup converter code. Use node model defaults as starting point.

* Preload the same libraries for CLI as for Sandbox.

* Add color support

* Simplify json

* Update file format.

* Remove property expressions.

* Restore comment.

* Restore Cef Settings

* Add unit test for CLI geometry option.

* Remove comment.

* Don't extend CommandLineRunner.

* Use var when possible.

* Remove commented out code.

* Use DynamoViewModel in CLI.

* Use DefaultWatch3DViewModel for CLI.

* Add new project DynamoWPFCLI.

* Let CommandLineRunnerWPF inherit from CommandLineRunner.

* Fix review comments.

* Fix unstable unit tests.

* Remove Dispose method.

* Add comments
* first commit - seems to be working
needs tests

* get rid of nodeViewModel converter

* add tests
fix comment
scottmitchell and others added 29 commits December 12, 2018 09:39
…9301)

* update

* Created a TagDictionary property that is cached and only rebuilt when necessary.

* Revert AssemblySharedInfo.cs..

* Simplified tagDictionary
… string matching (#9312)

* Update changes from librarie.js to fix QNTM-3710

* Add initial logging to the search dictionary

* Update output message

* Add returned count to the logging after the Search method is called

* Fix merge of tagDictionary changes

* Only return the first 20 search results (will be placed under a debug mode after running CI)

* Put search result truncation behind a debug mode

* Add commentds to the constructors

* Remove unused code
#9287)

* Add check for invalid cutom node name

https://jira.autodesk.com/browse/QNTM-3928

* Removing trailing spaces

* Moving the function to utilities class

* Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"

This reverts commit 085fb51, reversing
changes made to d055de4.

* Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo""

This reverts commit 12538ab.

* Adding tests - QNTM-3928

* Comments

* Moving the test to NodeViewCustomizationTests.cs

* Deleting changes to SerializationTests.cs

* Create SerializationTests.cs

* Update SerializationTests.cs

* moving the test to UtilityTests.ca
* Added Experimental Search item to debug menu

* Added Experimental Search item to debug menu

* Adding mechanism to turn ExperimentalSearch on and off

* moved Experimental Search to Settings > Experimental

* Cleaned up Experimental Search

* Cleaned up Experimental Search

* Revert AssemblySharedInfo. Added summaries for public API

* Revert AssemblySharedInfo. Added summaries for public API

* Made ExperimentalSearch bool private

* Revert resources

* Added Experimental Search resource

* Insert full query at front of subpatterns list

* updating Experimental Search access

* Updated resources. Added comments.

* Removed unnecessary experimentalSearch backing field
…9309)

* update libG lookup logic to include more clients and more tolerent

* Address Comments

* more clean up

* comments

* Some Comments and CleanUp

* Add Unit tests for version fallback and same products with same ASM

* Revert function obsolete and rename the one working with multiple products

* Add comments to public properties
* Update changes from librarie.js to fix QNTM-3710

* Remove unneeded logging
* enable node migration using the Migrations.xml file sometimes included with packages for 2.0+ graphs

* cleanup logic

* add additional comments

* more logic cleanup

* enable nodeModel node migration using the `AlsoKnownAs` attribute for JSON 2.0+ graphs

* cleanup

* update comment

* replace ContainsKey with TryGetValue

* mark previously used method as [Obsolete] to prevent breaking API

* more logic cleanup

* testing coverage on JSON node migration for ZeroTouch and NodeModel nodes

* update [Obsolete] message

* remove unnecessary pkg files

* remove more unnecessary pkg files

* remove package count test as it could easily change when new tests are added

* address coding standard comments

* accidental commit
* fix unmarshaling of nested DS Dictionary

* attempt 2

* add test nodes

* final fixes

* add tests
* update preview for multi-output node

* add recorded test
* fix partial multi-output custom node AST

* cleanup

* revert unchanged files

* revert unchanged files
* Fix Typos

* Revert one change
* update

* Brought truncated search results and full query search out from behind debug menu. Deleted debug menu items.

* revert AssemblySharedInfo

* Updated search dicitonary to return top 30 results

* Revert search dicitonary to return top 20 results
* "LibG/ASM223,eccc8d3f"

* "LibG/ASM224,01c57ca7"

* "LibG/ASM224.4,cf375341"

* "LibG/ASM225,b5e1f1fc"
* Add check for invalid cutom node name

https://jira.autodesk.com/browse/QNTM-3928

* Removing trailing spaces

* Moving the function to utilities class

* Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"

This reverts commit 085fb51, reversing
changes made to d055de4.

* Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo""

This reverts commit 12538ab.

* Adding tests - QNTM-3928

* Comments

* Moving the test to NodeViewCustomizationTests.cs

* Deleting changes to SerializationTests.cs

* Create SerializationTests.cs

* Update SerializationTests.cs

* moving the test to UtilityTests.ca

* Heterogeneous list update gives infinite loop

DYN-1198

* Moving the test dyn file
* this works - but I am hesitant to modify this replacer.
Not sure how this effects node2code. - may create rewriter directly.

* add a new visitor method for typedIdentifierNode
use it in custmNodeManager collapse method

* move shortQualifiedNameReplacer
update references
add comments to node2code mutation tests

* add more tests
add extra logic to deserialization for symbol node element resolver cache

* revert public API break, keep rewriter in dynamoCore but in new file

* remove extra usings added previously.

* remove debugging code
* Revert "Remove and Sort Usings (#9352)"

This reverts commit 8afcde0.

* Revert "Bump Version Number and RevisionNumber time baseline (#9336)"

This reverts commit 24c4e77.

* Revert "Heterogeneous list update gives infinite loop (#9334)"

This reverts commit 67a19a7.
* Add a new static function for preloader lookup

* Find the cloest version of preloader from ASM version

* Add Unit Test

* Address comments

* Fix null case and regression

* Update Unit test and address comments

* Update exception message
* Remove Legacy LibG

* Remove ASM legacy versions as lookup version params
* "LibG/ASM223,eccc8d3f"

* "LibG/ASM224,01c57ca7"

* "LibG/ASM223,030a7064"

* "LibG/ASM224,f5bf9edf"

* "LibG/ASM224.4,e98d33d3"

* "LibG/ASM225,55977695"
* first commit - add new argument to options
import libraries

* add tests
add functionality to WPF CLI
fix cli command parser for tests

* finish comment

* add new test dyns

* add comments to tests
* Revert "Cli import arg (#9366)"

This reverts commit 92979dc.

* Revert "LibG Binaries Update (#9371)"

This reverts commit 3591642.

* Revert "Remove Legacy LibG Versions (#9358)"

This reverts commit 0622384.
use config file to set switch
* SaveDropDownSelectedItem

* Updates to use internal cate

* Update comments

* Update the syncing logic

* Add Dynamo 2.1 Dropdown Unit Tests

* Add XML tests

* Update Unit tests
@radumg radumg merged commit 1ecb8c7 into radumg:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.