Skip to content

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 2, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Since Revit 2020 is finalizing dll lists, this is a good chance for the team to remove the two very old libG folders since there is no need for them to be shipped with Revit 2020. If we do not remove them for now and decide to remove them in a future Dynamo 2.x version, Revit2020 patch update will fail to remove these dlls.

FYI: @aparajit-pratap @mjkkirschner @alfarok @ColinDayOrg @scottmitchell @reddyashish

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap

FYIs

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Jan 3, 2019

Thanks @QilongTang! BTW while you're at it could you also remove all references for these older versions such as here:

new Version(222,0,0),
and similarly elsewhere where they might occur.

@QilongTang
Copy link
Contributor Author

QilongTang commented Jan 3, 2019

@aparajit-pratap Will do.

Update: I left mention of 222 in libG tests and public enum untouched, only two appearances left, both removed

@QilongTang QilongTang merged commit 0622384 into master Jan 3, 2019
@QilongTang QilongTang deleted the RemoveLegacyLibG branch January 3, 2019 19:58
QilongTang added a commit that referenced this pull request Jan 3, 2019
* Remove Legacy LibG

* Remove ASM legacy versions as lookup version params
QilongTang added a commit that referenced this pull request Jan 7, 2019
QilongTang added a commit that referenced this pull request Jan 7, 2019
* Revert "Cli import arg (#9366)"

This reverts commit 92979dc.

* Revert "LibG Binaries Update (#9371)"

This reverts commit 3591642.

* Revert "Remove Legacy LibG Versions (#9358)"

This reverts commit 0622384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants