Reverting public API signature changes made in #8734 #8738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update tests
Member
|
@aparajit-pratap this is probably a better way to go... I will cancel the 1598 build which I started to push a new nuget. |
Member
|
@aparajit-pratap - is there any issue if an API client calls this API with an empty list instead of null? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Reverting public API signature changes made in #8734 so that no API breaking changes would be made and that no new NuGet's need to be published.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner - I leave it up to you to decide if this is necessary. Advantage of doing so is that no unnecessary NuGet packages need to be posted again.
FYIs
@jnealb