Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Dec 19, 2018

Purpose

Following PR #9320, this fixes 2 test failures with partial, multi-output custom nodes breaking. This uncovered a bug in the AST creation for such nodes. The extra AST to create a Dictionary in BuildAstForPartialMultiOutput is not required and therefore the base class method need not be overridden in the CustomNodeController. It feels good to fix bugs by removing code :)

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@alfarok
@mjkkirschner

@aparajit-pratap aparajit-pratap merged commit bc1df73 into DynamoDS:master Dec 19, 2018
@aparajit-pratap aparajit-pratap deleted the customNode branch December 19, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant