fix partial multi-output custom node AST #9327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Following PR #9320, this fixes 2 test failures with partial, multi-output custom nodes breaking. This uncovered a bug in the AST creation for such nodes. The extra AST to create a Dictionary in
BuildAstForPartialMultiOutputis not required and therefore the base class method need not be overridden in theCustomNodeController. It feels good to fix bugs by removing code :)Declarations
Check these if you believe they are true
*.resxfilesReviewers
@alfarok
@mjkkirschner